After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735681 - OSK sends double key presses
OSK sends double key presses
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: keyboard
unspecified
Other Mac OS
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 735780 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-08-29 18:03 UTC by Carlos Garnacho
Modified: 2014-09-01 19:33 UTC
See Also:
GNOME target: 3.14
GNOME version: ---


Attachments
Revert "keyboard: Handle touch events" (2.08 KB, patch)
2014-09-01 19:33 UTC, Carlos Garnacho
committed Details | Review

Description Carlos Garnacho 2014-08-29 18:03:41 UTC
Since commit a84fb99c0aca9f the OSK is sending double key presses, one for the touch events in the passive grab, and another for the button events gotten after rejecting the touch.

For the mid/longer term (eg past 3.14), we want the shell to not resort to pointer emulation, and if possible deal sanely with the double touch emission due to passive grab + event selection. For the very short term, I suggest to just revert that commit, it's hurting on x11 and doesn't actually send any key events yet on Wayland, even if the keyboard is interactive.
Comment 1 Florian Müllner 2014-09-01 05:05:00 UTC
*** Bug 735780 has been marked as a duplicate of this bug. ***
Comment 2 Carlos Garnacho 2014-09-01 19:33:04 UTC
The following fix has been pushed:
032a688 Revert "keyboard: Handle touch events"
Comment 3 Carlos Garnacho 2014-09-01 19:33:11 UTC
Created attachment 285066 [details] [review]
Revert "keyboard: Handle touch events"

This reverts commit a84fb99c0aca9fd6eeb83a270c48113133e89de2.

This commit didn't make the OSK fully operational yet on Wayland, and
caused the double emission of key events on X11 due to the OSK keys
receiving first touch events from the passive touch grab, and then
emulated pointer events from event selection after the touch sequence
was rejected in the grab.

When we make a better effort at handling touch events just once on X11,
this commit can be reapplied and remaining wayland OSK support resumed
from there. In the mean time, this patch is better reverted.