After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735680 - GdNotification is busted, port to GtkPopover ?
GdNotification is busted, port to GtkPopover ?
Status: RESOLVED FIXED
Product: libgd
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: libgd maintainer(s)
libgd maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-29 17:45 UTC by Rui Matos
Modified: 2014-09-03 11:13 UTC
See Also:
GNOME target: 3.14
GNOME version: ---

Attachments
region: Port notification to GtkPopover (4.90 KB, patch)
2014-08-29 17:45 UTC, Rui Matos 		rejected Details | Review
user-accounts: Port notification to GtkPopover (5.08 KB, patch)
2014-08-29 17:45 UTC, Rui Matos 		rejected Details | Review
build: Stop building GdNotification as it's not needed anymore (833 bytes, patch)
2014-08-29 17:45 UTC, Rui Matos 		rejected Details | Review
Fix GdNotification rendering (5.62 KB, patch)
2014-09-03 03:51 UTC, Matthias Clasen 		committed Details | Review

Description Rui Matos 2014-08-29 17:45:26 UTC 
This is how it currently looks https://i.imgur.com/S7DlPND.png

I thought that we could just port it to use GtkPopover and reduce our
usage of libgd even further.
Comment 1 Rui Matos 2014-08-29 17:45:29 UTC 
Created attachment 284828 [details] [review]
region: Port notification to GtkPopover
Comment 2 Rui Matos 2014-08-29 17:45:35 UTC 
Created attachment 284829 [details] [review]
user-accounts: Port notification to GtkPopover
Comment 3 Rui Matos 2014-08-29 17:45:39 UTC 
Created attachment 284830 [details] [review]
build: Stop building GdNotification as it's not needed anymore
Comment 4 Matthias Clasen 2014-09-01 13:48:48 UTC 
I don't think a popover should be misused for a notification. What you are seeing with GdNotification is a theming bug that clearly needs to be fixed
Comment 5 Bastien Nocera 2014-09-01 13:50:46 UTC 
Agreed. We had the same problem for the "popup status bar" in nautilus and epiphany during this cycle.
Comment 6 Matthias Clasen 2014-09-03 03:51:03 UTC 
Created attachment 285217 [details] [review]
Fix GdNotification rendering

Adwaita provides styling only for .app-notification.frame, so
add the .frame style class as well. And don't draw a shadow.
Comment 7 Bastien Nocera 2014-09-03 11:13:21 UTC 
Attachment 285217 [details] pushed as 2899de0 - Fix GdNotification rendering