GNOME Bugzilla – Bug 735649
Add tooltips to buttons on new dialogs
Last modified: 2014-08-29 13:05:55 UTC
These icons are still unclear and probably should be replaced with text buttons, but this probably requires designer attention, so for now let's just add tooltips to these buttons instead. Would be nice to get these in before string freeze.
Created attachment 284777 [details] [review] cookies-dialog: add tooltip to remove cookie button
Created attachment 284778 [details] [review] history-dialog: add tooltips to buttons
Created attachment 284779 [details] [review] passwords-dialog: add tooltips to buttons
Review of attachment 284777 [details] [review]: ::: src/resources/cookies-dialog.ui @@ +137,3 @@ <property name="use_underline">True</property> <property name="icon_name">list-remove-symbolic</property> + <property name="tooltip_text" translatable="yes">Delete the selected cookie</property> Note that multiple selection is allowed, so maybe this should be plural, the selected cookies.
Review of attachment 284778 [details] [review]: Same here, it seems the history dialog also allows multiple selections
Review of attachment 284779 [details] [review]: Not sure about this one, I don't have passwords, but I guess it also allows multiple selections.
Created attachment 284810 [details] [review] cookies-dialog: add tooltip to remove cookie button
Created attachment 284811 [details] [review] history-dialog: add tooltips to buttons
Created attachment 284812 [details] [review] passwords-dialog: add tooltips to buttons
Comment on attachment 284810 [details] [review] cookies-dialog: add tooltip to remove cookie button Thanks
Attachment 284810 [details] pushed as 2d1db96 - cookies-dialog: add tooltip to remove cookie button Attachment 284811 [details] pushed as ca8ef0d - history-dialog: add tooltips to buttons Attachment 284812 [details] pushed as 6430219 - passwords-dialog: add tooltips to buttons