After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735610 - Remove requirement on ModulePath for extractor .rule files
Remove requirement on ModulePath for extractor .rule files
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: Extractor
git master
Other Linux
: Normal normal
: ---
Assigned To: tracker-extractor
tracker-extractor
Depends on:
Blocks:
 
 
Reported: 2014-08-28 15:51 UTC by Bastien Nocera
Modified: 2015-07-12 19:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
libtracker-extract: Accept rules with no ModulePath (1.32 KB, patch)
2014-08-28 16:09 UTC, Carlos Garnacho
needs-work Details | Review

Description Bastien Nocera 2014-08-28 15:51:16 UTC
A number of file types, such as the ones listed in bug 735460, have no format-specific extractors, or contain no metadata that could be extracted by those. Instead of using a dummy extractor, we should be able to remove the requirement for a ModulePath to be set in the .rule files.
Comment 1 Carlos Garnacho 2014-08-28 16:09:42 UTC
Created attachment 284720 [details] [review]
libtracker-extract: Accept rules with no ModulePath

This will enable us to make dummy rules for files that must have some RDF
type(s), but don't have an extractor module.
Comment 2 Martyn Russell 2014-08-29 08:51:51 UTC
Comment on attachment 284720 [details] [review]
libtracker-extract: Accept rules with no ModulePath

Hi Carlos, the patch mostly looks good. 

If the module_path assignment fails, we leak a GError here since we don't return and could possibly assign the GError later in the code. We should probably g_clear_error (&error) somewhere there.

The rest looks good to me :)
Comment 3 Martyn Russell 2015-07-12 19:19:52 UTC
I've pushed this and a fix to check the error return value too.
Thanks Carlos.


commit 06f7d4a1abfdcb6fbd8828cc7221e64d871e1877
Author: Carlos Garnacho <carlosg@gnome.org>
Date:   Thu Aug 28 18:02:51 2014 +0200

    libtracker-extract: Accept rules with no ModulePath
    
    This will enable us to make dummy rules for files that must have some RDF
    type(s), but don't have an extractor module.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735610