GNOME Bugzilla – Bug 735610
Remove requirement on ModulePath for extractor .rule files
Last modified: 2015-07-12 19:19:52 UTC
A number of file types, such as the ones listed in bug 735460, have no format-specific extractors, or contain no metadata that could be extracted by those. Instead of using a dummy extractor, we should be able to remove the requirement for a ModulePath to be set in the .rule files.
Created attachment 284720 [details] [review] libtracker-extract: Accept rules with no ModulePath This will enable us to make dummy rules for files that must have some RDF type(s), but don't have an extractor module.
Comment on attachment 284720 [details] [review] libtracker-extract: Accept rules with no ModulePath Hi Carlos, the patch mostly looks good. If the module_path assignment fails, we leak a GError here since we don't return and could possibly assign the GError later in the code. We should probably g_clear_error (&error) somewhere there. The rest looks good to me :)
I've pushed this and a fix to check the error return value too. Thanks Carlos. commit 06f7d4a1abfdcb6fbd8828cc7221e64d871e1877 Author: Carlos Garnacho <carlosg@gnome.org> Date: Thu Aug 28 18:02:51 2014 +0200 libtracker-extract: Accept rules with no ModulePath This will enable us to make dummy rules for files that must have some RDF type(s), but don't have an extractor module. https://bugzilla.gnome.org/show_bug.cgi?id=735610