After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735608 - workspace: Always remove removed windows
workspace: Always remove removed windows
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-28 14:39 UTC by Florian Müllner
Modified: 2014-08-28 14:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
workspace: Always remove removed windows (1.64 KB, patch)
2014-08-28 14:39 UTC, Florian Müllner 		committed Details | Review

Description Florian Müllner 2014-08-28 14:39:20 UTC 
Fallout from the workspace rewrite - to reproduce:
(1) Go to overview
(2) Drag a window to another workspace in the switcher

The window is moved to the new workspace, but its preview is not removed from the old workspace. Attached patch appears to work in testing without any obvious regressions, but I may be overlooking something ...
Comment 1 Florian Müllner 2014-08-28 14:39:23 UTC 
Created attachment 284706 [details] [review]
workspace: Always remove removed windows

Since mutter commit 527c53a2a0582eba, MetaWorkspace::window-removed
is emitted *before* MetaWindow:workspace is updated, so the test
whether the removed window should still be on the workspace in
question will always return true.
Assume the test is no longer necessary nowadays to fix this very
obvious regression.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-08-28 14:56:40 UTC 
Review of attachment 284706 [details] [review]:

Yeah, makes sense. I'm surprised we were relying on this really weird API assumption.
Comment 3 Florian Müllner 2014-08-28 14:58:21 UTC 
Attachment 284706 [details] pushed as c9f3afc - workspace: Always remove removed windows