After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735562 - Remove deprecate API from bookmarks
Remove deprecate API from bookmarks
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-28 02:26 UTC by José Aliste
Modified: 2014-08-28 14:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell: Don't use gtk_button_new_from_stock (1.49 KB, patch)
2014-08-28 02:26 UTC, José Aliste 		committed Details | Review

Description José Aliste 2014-08-28 02:26:21 UTC 
Currently we use gtk_button_new_from_stock 
for the add and remove buttons. We should use
gtk_button_new_with_label instead. 

The following patch is expected to be committed 
after the freeze, because we modify strings
Comment 1 José Aliste 2014-08-28 02:26:24 UTC 
Created attachment 284653 [details] [review]
shell: Don't use gtk_button_new_from_stock

This is deprecated in 3.10
Comment 2 Carlos Garcia Campos 2014-08-28 13:20:31 UTC 
Comment on attachment 284653 [details] [review]
shell: Don't use gtk_button_new_from_stock

Strings aren't frozen yet.
Comment 3 José Aliste 2014-08-28 14:02:39 UTC 
Review of attachment 284653 [details] [review]:

pushed
Comment 4 José Aliste 2014-08-28 14:02:59 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.