After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735540 - Remove Close from window menu
Remove Close from window menu
Status: RESOLVED OBSOLETE
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks: 755524
 
 
Reported: 2014-08-27 18:55 UTC by Michael Catanzaro
Modified: 2016-09-22 22:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove Close from window menu (1.04 KB, patch)
2014-08-27 18:55 UTC, Michael Catanzaro 		reviewed Details | Review

Description Michael Catanzaro 2014-08-27 18:55:07 UTC 
Remove it from the menu, but keep the action around so that the accelerator still works.
Comment 1 Michael Catanzaro 2014-08-27 18:55:09 UTC 
Created attachment 284628 [details] [review]
Remove Close from window menu

"Header bar menus shouldn't include a close menu item, since this action
is already provided by the header bar. It can also be ambiguous as to
what a close menu item refers to." -- new HIG
Comment 2 Carlos Garcia Campos 2015-02-03 11:57:07 UTC 
Review of attachment 284628 [details] [review]:

The close button in the header bar is to close the window, while the close action of the gear menu is to close the current tab, so they are not equivalent.

::: src/resources/epiphany-ui.xml
@@ -46,3 @@
                 <menuitem name="HelpContentsMenu" action="HelpContents"/>
                 <menuitem name="HelpAboutMenu" action="HelpAbout"/>
-                <menuitem name="FileCloseWindowMenu" action="FileCloseTab"/>

I agree it's quite confusing having a menu item called FileCloseWindowMenu when its action is FileCloseTab
Comment 3 Michael Catanzaro 2015-02-03 14:44:58 UTC 
Well we could rename it to Close Tab but I would still rather remove it; there are close buttons on each tab, so who would open the hamburger menu to close a tab? There's also no space for it in a popover-style menu. OTOH we could leave it be for now and remove it when switching to a popover menu.