GNOME Bugzilla – Bug 735539
Do not show Close in window menu
Last modified: 2014-10-16 04:41:20 UTC
Our new HIG say we should not do this.
Created attachment 284626 [details] [review] Do not show Close in window menu "Header bar menus shouldn't include a close menu item, since this action is already provided by the header bar. It can also be ambiguous as to what a close menu item refers to." -- the HIG
Review of attachment 284626 [details] [review]: Rationale makes sense... Does Ctrl+W still work without the action? I also think it might be a little too late for this to go in 3.14, but I'm open to the possibility.
Nope, I broke Ctrl+W. Let's try this again.... I guess this probably would be more appropriate for 3.16, but I think it's not a big deal either way. If you mark it accept-commit-after-freeze, I'll do that.
Created attachment 284646 [details] [review] Do not show Close in header bar menu "Header bar menus shouldn't include a close menu item, since this action is already provided by the header bar. It can also be ambiguous as to what a close menu item refers to." -- the HIG
Review of attachment 284646 [details] [review]: I think this can go in after freeze.
@Michael Catanzaro: we're after the freeze, I guess you could get the patch in master, as per the review.
We have to branch first; are you ready for that, Cosimo?
Yes, branched and pushed now.
(In reply to comment #4) > "Header bar menus shouldn't include a close menu item, since this action > is already provided by the header bar. It can also be ambiguous as to > what a close menu item refers to." -- the HIG A small correction, this action isn't provided by header bar, because "Close" on menu doesn't close application, but tabs.