After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735491 - Enable warnings when compiling the web extension
Enable warnings when compiling the web extension
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-26 23:24 UTC by Michael Catanzaro
Modified: 2014-08-27 12:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Enable warnings when compiling the web extension (1.45 KB, patch)
2014-08-26 23:24 UTC, Michael Catanzaro 		committed Details | Review
ephy-web-extension: silence some warnings (1.87 KB, patch)
2014-08-26 23:31 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-08-26 23:24:05 UTC 
We've been compiling the web extension without any warnings (which we place into AM_CFLAGS in configure.ac)
Comment 1 Michael Catanzaro 2014-08-26 23:24:06 UTC 
Created attachment 284565 [details] [review]
Enable warnings when compiling the web extension

By accident, we don't use any compiler warnings when compiling the web
extension. This is bad.

We must either add -Wno-missing-prototypes or else declare a useless
prototype for webkit_web_extension_initialize_with_user_data().
Comment 2 Michael Catanzaro 2014-08-26 23:31:12 UTC 
Created attachment 284567 [details] [review]
ephy-web-extension: silence some warnings
Comment 3 Carlos Garcia Campos 2014-08-27 07:04:50 UTC 
Comment on attachment 284565 [details] [review]
Enable warnings when compiling the web extension

Ok
Comment 4 Carlos Garcia Campos 2014-08-27 07:05:30 UTC 
Comment on attachment 284567 [details] [review]
ephy-web-extension: silence some warnings

Ok
Comment 5 Michael Catanzaro 2014-08-27 12:54:38 UTC 
Attachment 284565 [details] pushed as 4209900 - Enable warnings when compiling the web extension
Attachment 284567 [details] pushed as b1c2a76 - ephy-web-extension: silence some warnings