After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735465 - embed/web-extension/ephy-web-extension.c: Non-void function should return a value
embed/web-extension/ephy-web-extension.c: Non-void function should return a v...
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Build
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-26 17:20 UTC by Ting-Wei Lan
Modified: 2014-08-27 09:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "Non-void function should return a value" (834 bytes, patch)
2014-08-26 17:20 UTC, Ting-Wei Lan 		needs-work Details | Review
Always calls JSValueMakeUndefined (context) before leaving the function (860 bytes, patch)
2014-08-26 17:56 UTC, Ting-Wei Lan 		accepted-commit_now Details | Review

Description Ting-Wei Lan 2014-08-26 17:20:53 UTC 
Created attachment 284522 [details] [review]
Fix "Non-void function should return a value"

In embed/web-extension/ephy-web-extension.c, a return value is missing in allow_tls_certificate_cb.
Comment 1 Michael Catanzaro 2014-08-26 17:34:31 UTC 
Review of attachment 284522 [details] [review]:

Thank you!

I think we always need to call JSValueMakeUndefined (context) before leaving the function.
Comment 2 Ting-Wei Lan 2014-08-26 17:56:32 UTC 
Created attachment 284525 [details] [review]
Always calls JSValueMakeUndefined (context) before leaving the function
Comment 3 Carlos Garcia Campos 2014-08-27 06:57:16 UTC 
Comment on attachment 284525 [details] [review]
Always calls JSValueMakeUndefined (context) before leaving the function

Thanks!