After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735456 - Smoketest is broken with latest systemd
Smoketest is broken with latest systemd
Status: RESOLVED FIXED
Product: gnome-continuous
Classification: Other
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Continuous maintainer(s)
GNOME Continuous maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-26 15:28 UTC by Vadim Rutkovsky
Modified: 2015-01-26 11:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Rework gnome-ostree-add-user service (2.71 KB, patch)
2014-08-26 15:28 UTC, Vadim Rutkovsky 		accepted-commit_now Details | Review

Description Vadim Rutkovsky 2014-08-26 15:28:48 UTC 
Created attachment 284514 [details] [review]
Rework gnome-ostree-add-user service

Systemd now doesn't support complex scripts in one ExecStart and disregards this service hence smoketests break as there is no user created.

The attached patch uses several ExecStart calls in the service and fixes the problem
Comment 1 Colin Walters 2014-08-26 15:32:49 UTC 
Review of attachment 284514 [details] [review]:

Looks fine, only one minor point.  Please commit after addressing.

::: src/js/libqa.js
@@ +246,3 @@
+        addUserService = addUserService + Format.vprintf('ExecStart=%s\n', [setSessionCommand]);
+    }
+    addUserService = addUserService + 'Type=oneshot\n';

Can't we just have Type=oneshot in the literal string at the start?
Comment 2 Vadim Rutkovsky 2014-08-26 15:39:55 UTC 
(In reply to comment #1)
> Can't we just have Type=oneshot in the literal string at the start?
Fixed and committed as https://git.gnome.org/browse/gnome-continuous/commit/?id=73d1511b9593437d5f68cb76b1507dd13c8ee519