After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735438 - Make all the message dialog to look like a real message dialog
Make all the message dialog to look like a real message dialog
Status: RESOLVED FIXED
Product: file-roller
Classification: Applications
Component: general
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: Paolo Bacchilega
file-roller-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-26 10:13 UTC by Yosef Or Boczko
Modified: 2014-10-26 18:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot - older message dialog (143.82 KB, image/png)
2014-08-26 10:19 UTC, Yosef Or Boczko 		  Details
Screenshot - new message dialog (151.88 KB, image/png)
2014-08-26 10:20 UTC, Yosef Or Boczko 		  Details
Make the message dialogs more modern (14.38 KB, patch)
2014-08-26 10:34 UTC, Yosef Or Boczko 		none Details | Review
Make the error dialogs more modern (13.13 KB, patch)
2014-08-26 12:00 UTC, Yosef Or Boczko 		none Details | Review
request-dialog: Remove the unneeded image (1.56 KB, patch)
2014-08-26 12:21 UTC, Yosef Or Boczko 		none Details | Review
file-selector-dialog: Use symbolic icon for the go up button (984 bytes, patch)
2014-08-26 13:06 UTC, Yosef Or Boczko 		none Details | Review

Description Yosef Or Boczko 2014-08-26 10:13:00 UTC 
Some message dialog looks ugly, like the olders messgae dialog.
We needs to make them from GtkMessageDialog and not from GtkDialog,
to get them to look like other apps.

Also, we don't needs icons in dialogs anymore.

I attached two screenshot, before and after, as an example.
Comment 1 Yosef Or Boczko 2014-08-26 10:19:54 UTC 
Created attachment 284487 [details]
Screenshot - older message dialog
Comment 2 Yosef Or Boczko 2014-08-26 10:20:14 UTC 
Created attachment 284488 [details]
Screenshot - new message dialog
Comment 3 Yosef Or Boczko 2014-08-26 10:34:32 UTC 
Created attachment 284489 [details] [review]
Make the message dialogs more modern
Comment 4 Yosef Or Boczko 2014-08-26 12:00:48 UTC 
Created attachment 284501 [details] [review]
Make the error dialogs more modern
Comment 5 Yosef Or Boczko 2014-08-26 12:21:53 UTC 
Created attachment 284502 [details] [review]
request-dialog: Remove the unneeded image

This patch not really relate to this bug, but I make here just more some
clean to the dialogs.
Comment 6 Yosef Or Boczko 2014-08-26 13:06:16 UTC 
Created attachment 284503 [details] [review]
file-selector-dialog: Use symbolic icon for the go up button
Comment 7 Paolo Bacchilega 2014-09-01 18:14:38 UTC 
Unfortunately we are in UI freeze already, this is 3.15.x material.
Comment 8 Paolo Bacchilega 2014-10-26 18:21:13 UTC 
Patches pushed to master now, thank you.