After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735437 - Getting multiarray over DBus
Getting multiarray over DBus
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: D-Bus
unspecified
Other All
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-26 09:23 UTC by Markus Siemer
Modified: 2018-05-14 06:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Testcase for Multiarray over DBus (1.26 KB, text/x-vala)
2014-08-26 09:23 UTC, Markus Siemer
  Details
gvariant module: fix serializing multidimensional arrays (1.98 KB, patch)
2015-09-14 09:38 UTC, Abderrahim Kitouni
none Details | Review
gvariant module: Fix serializing multidimensional arrays (4.39 KB, patch)
2016-09-17 19:39 UTC, Rico Tzschichholz
none Details | Review
gvariant module: Fix serializing multidimensional arrays (4.34 KB, patch)
2016-09-17 19:41 UTC, Rico Tzschichholz
none Details | Review
codegen: Fix serializing multidimensional arrays (4.17 KB, patch)
2018-05-12 12:07 UTC, Rico Tzschichholz
committed Details | Review

Description Markus Siemer 2014-08-26 09:23:07 UTC
Created attachment 284482 [details]
Testcase for Multiarray over DBus

I get the following errors while trying to get a double[,] array over DBus:

(process:6003): GLib-CRITICAL **: g_variant_builder_add_value: assertion '!GVSB(builder)->expected_type || g_variant_is_of_type (value, GVSB(builder)->expected_type)' failed

It results in wrong values in the received array.

Imo its an error in the vala compiler generating invalid C Code. I've attached an TestCase.

Thank you.
Comment 1 Abderrahim Kitouni 2015-09-14 09:38:31 UTC
Created attachment 311265 [details] [review]
gvariant module: fix serializing multidimensional arrays

I also had this bug and managed to fix it.
Comment 2 Rico Tzschichholz 2016-09-17 19:39:41 UTC
Created attachment 335772 [details] [review]
gvariant module: Fix serializing multidimensional arrays

The same type signature was being used for every dimension of the array.

https://bugzilla.gnome.org/show_bug.cgi?id=735437

https://bugzilla.gnome.org/show_bug.cgi?id=723258
Comment 3 Rico Tzschichholz 2016-09-17 19:41:35 UTC
Created attachment 335773 [details] [review]
gvariant module: Fix serializing multidimensional arrays

The same type signature was being used for every dimension of the array.
Comment 4 Rico Tzschichholz 2018-05-12 12:07:34 UTC
Created attachment 371954 [details] [review]
codegen: Fix serializing multidimensional arrays

The same type signature was being used for every dimension of the array.

Based on patch by Abderrahim Kitouni
Comment 5 Rico Tzschichholz 2018-05-14 06:19:06 UTC
Attachment 371954 [details] pushed as 6b514c6 - codegen: Fix serializing multidimensional arrays