After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735309 - Adblock doesn't work for some ads
Adblock doesn't work for some ads
Status: RESOLVED DUPLICATE of bug 775736
Product: epiphany
Classification: Core
Component: General
git master
Other Linux
: Normal normal
: ---
Assigned To: Michael Catanzaro
Epiphany Maintainers
Depends on:
Blocks: 776514
 
 
Reported: 2014-08-24 06:56 UTC by ChangSeok Oh
Modified: 2016-12-26 23:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a test case (412 bytes, text/html)
2014-08-24 06:56 UTC, ChangSeok Oh 		Details

Description ChangSeok Oh 2014-08-24 06:56:03 UTC 
Created attachment 284328 [details]
a test case

Loading and parsing adblock filter is changed to run asynchronously in bug 730129. It has improved performance at starting time though, it has broken the functionality itself. The core reason is that the filter loading happens after sending requests at beginning. When I revert https://git.gnome.org/browse/epiphany/commit/?id=cc7cc7a619da7a7bc1a4b9a10be664824dee5777, adblock works again.
Attached a testcase for this.
Comment 1 Michael Catanzaro 2014-08-24 14:50:52 UTC 
That commit looks wrong; either uri_tester_parse_file_at_uri() should not return until all the filters have been parsed, or else uri_tester_test_uri() needs to block and not check the uri before all filters have been loaded.  But the intent behind that commit was probably to avoid blocking the web process when loading filters. I guess the way to achieve both goals is to have the UriTester start parsing filters asynchronously as soon as the web extension starts.
Comment 2 Michael Catanzaro 2016-12-26 23:00:49 UTC 
Ah, I rediscovered this problem recently. Shame the offending commits were not reverted years ago. :(

*** This bug has been marked as a duplicate of bug 775736 ***