After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735224 - [PATCH] Don't create more than one preferences' dialog.
[PATCH] Don't create more than one preferences' dialog.
Status: RESOLVED FIXED
Product: iagno
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: iagno-maint
iagno-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-22 14:46 UTC by Arnaud B.
Modified: 2014-08-22 18:10 UTC
See Also:
GNOME target: ---
GNOME version: 3.13/3.14

Attachments
Don't create more than one preferences' dialog. (2.14 KB, patch)
2014-08-22 14:46 UTC, Arnaud B. 		reviewed Details | Review
Don't create more than one preferences' dialog. (2.13 KB, patch)
2014-08-22 15:16 UTC, Arnaud B. 		committed Details | Review

Description Arnaud B. 2014-08-22 14:46:13 UTC 
Created attachment 284218 [details] [review]
Don't create more than one preferences' dialog.

A new preferences’ dialog is created each time “Preferences” is clicked in the app’menu. So, you could have more than one on the screen…
Comment 1 Michael Catanzaro 2014-08-22 14:57:39 UTC 
Review of attachment 284218 [details] [review]:

Nits:

::: src/iagno.vala
@@ +29,3 @@
     private Gtk.Label light_label;
     private Gtk.Label light_score_label;
+    private Gtk.Dialog propbox = null;

It's really pathetic that Vala accepts code like this. :/  This variable should be a nullable Gtk.Dialog? but I don't know why Vala has nullable variables at all if it doesn't enforce them.

@@ +384,3 @@
+        if (propbox == null)
+            create_preferences_dialog ();
+        propbox.show_all     ();

tab ?
Comment 2 Arnaud B. 2014-08-22 15:16:44 UTC 
Created attachment 284240 [details] [review]
Don't create more than one preferences' dialog.