Bug 735210 – Annotate GstPadEventFunction @event with (transfer full)

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 735210 - Annotate GstPadEventFunction @event with (transfer full)


Summary:	Annotate GstPadEventFunction @event with (transfer full)


Status:	RESOLVED FIXED

Product:	GStreamer
Classification:	Platform
Component:	documentation
Version:	unspecified
Hardware:	Other Linux

Importance:	Normal enhancement
Target Milestone:	1.5.1
Assigned To:	GStreamer Maintainers
QA Contact:	GStreamer Maintainers

URL:
Whiteboard:

Depends on:
Blocks:

Reported:	2014-08-22 08:32 UTC by Guillaume Desmottes
Modified:	2014-08-23 11:36 UTC

See Also:
GNOME target:	---
GNOME version:	---

Attachments
pad: annotate GstPadEventFunction @event with (transfer full) (1.02 KB, patch) 2014-08-22 08:33 UTC, Guillaume Desmottes	committed	Details \| Review

Description Guillaume Desmottes 2014-08-22 08:32:27 UTC

Make things clearer.

Comment 1 Guillaume Desmottes 2014-08-22 08:33:31 UTC

Created attachment 284169 [details] [review]
pad: annotate GstPadEventFunction @event with (transfer full)

The callback is supposed to take ownership of @event so best to be explicit
about it.

Comment 2 Tim-Philipp Müller 2014-08-23 11:36:36 UTC

Thanks for the patch, pushed to master:

commit b38264a9cb6096f9a92ee45ea0c084c7a877c0c4
Author: Tim-Philipp Müller <tim@centricular.com>
Date:   Sat Aug 23 12:24:27 2014 +0100

    pad: add g-i 'transfer full' annotations to chain and chain_list functions
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735210

commit a647d832671eba2001c12a7061ccde5996ebe47e
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Fri Aug 22 10:32:38 2014 +0200

    pad: annotate GstPadEventFunction event with 'transfer full'
    
    The callback is supposed to take ownership of the event so
    best to be explicit about it.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=735210

(Here's hoping g-i + bindings won't do anything funny with this)