After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735206 - Remove gi._gi._glib and gi._gi._gobject internal modules
Remove gi._gi._glib and gi._gi._gobject internal modules
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks: 677091
 
 
Reported: 2014-08-22 01:17 UTC by Simon Feltman
Modified: 2017-04-01 09:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Remove gi._gi._glib module (13.43 KB, patch)
2017-03-27 05:44 UTC, Christoph Reiter (lazka)
committed Details | Review
Remove gi._gi._gobject and gi._gobject modules (37.47 KB, patch)
2017-03-27 08:19 UTC, Christoph Reiter (lazka)
committed Details | Review

Description Simon Feltman 2014-08-22 01:17:24 UTC
We currently create three internal modules from our single extension module. This should be cleaned up and static methods found in gi/glibmodule.c and gi/gobjectmodule.c should be moved into the method table in gi/gimodule.c.

These are remnants that are left over from fixing bug 712197. Since some of these functions are static to the modules in question, they can be divvied into C modules of a related functionality and exposed in header files for inclusion into the gi extension module function table. For instance:

gi/gobjectmodule.c:
   pyg_type_name -> pygtype.[h|c]
   pyg_type_from_name -> pygtype.[h|c]
   pyg_type_is_a -> pygtype.[h|c]
   type_register -> pygtype.[h|c]
   _gvalue_get -> pygi-value.[h|c]
   _gvalue_set -> pygi-value.[h|c]

(eventually pygtype.[h|c] should be merged into pygi-type.[h|c])
Comment 1 Christoph Reiter (lazka) 2017-03-27 05:44:23 UTC
Created attachment 348769 [details] [review]
Remove gi._gi._glib module

Move the code into gi._gi (gimodule)
The module was a leftover from https://bugzilla.gnome.org/show_bug.cgi?id=712197
Comment 2 Christoph Reiter (lazka) 2017-03-27 08:19:46 UTC
Created attachment 348775 [details] [review]
Remove gi._gi._gobject and gi._gobject modules

Expose everything from _gi._gobject in _gi instead.
This does not move any code around, just removes the module.

Also removes the gi._gobject package and replaces it
with a small dummy module in gi.__init__.py