After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735199 - Replace statically bound GLib.Variant.new_tuple() with GI
Replace statically bound GLib.Variant.new_tuple() with GI
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks: 685373
 
 
Reported: 2014-08-21 22:12 UTC by Simon Feltman
Modified: 2015-01-24 17:17 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Replace statically bound GLib.Variant.new_tuple() with GI (3.84 KB, patch)
2014-08-21 22:13 UTC, Simon Feltman
committed Details | Review

Description Simon Feltman 2014-08-21 22:12:54 UTC
The static implementation of g_variant_new_tuple() is no longer needed as the introspection version works fine.
Comment 1 Simon Feltman 2014-08-21 22:13:58 UTC
Created attachment 284150 [details] [review]
Replace statically bound GLib.Variant.new_tuple() with GI

Remove the static implementation of _wrap_pyg_variant_new_tuple with
usage of the dynamic version coming from GI. Array marshalling has
drastically improved in recent years making the dynamic version usable
with a small compatibility shim for the arguments.
Comment 2 Simon Feltman 2015-01-24 17:17:46 UTC
Note new_tuple() is tested within:
https://git.gnome.org/browse/pygobject/tree/tests/test_overrides_glib.py?id=3.14.0

Attachment 284150 [details] pushed as 4d0ab13 - Replace statically bound GLib.Variant.new_tuple() with GI