After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735180 - Typo
Typo
Status: RESOLVED FIXED
Product: tracker
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: tracker-general
Depends on:
Blocks:
 
 
Reported: 2014-08-21 18:03 UTC by Alexandre Franke
Modified: 2014-09-19 14:08 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Alexandre Franke 2014-08-21 18:03:24 UTC
In src/tracker-utils/tracker-info.c:65

"Instead of looking up a file name, treat the FILE arguments as actual IRIs (e.g. <file:///path/to/some/file.txt>)"

It should be "URI", not "IRI".
Comment 1 Martyn Russell 2014-08-22 09:37:07 UTC
(In reply to comment #0)
> In src/tracker-utils/tracker-info.c:65
> 
> "Instead of looking up a file name, treat the FILE arguments as actual IRIs
> (e.g. <file:///path/to/some/file.txt>)"
> 
> It should be "URI", not "IRI".

Hi there.

Actually, it shouldn't be URI at all.

If anything it should be IRI or URN. The difference is that IRI allows for UTF-8 "URNs", where as URN is supposed to be ASCII encoded.

Given that so many terminals these days (and most of Tracker internally) deals with UTF-8 strings, it is more correct to allow and use IRI for the command line than URI.

Having said all that, I don't think we're very consistent in some places and I dare say the command line tools could all do with being updated/fixed accordingly.
Comment 2 Alexandre Franke 2014-08-22 09:40:33 UTC
Ah, I didn't know IRI was an actual thing. Sorry about that. Maybe you should at least add a translator comment to explain what it's supposed to mean?
Comment 3 Martyn Russell 2014-08-22 09:42:11 UTC
(In reply to comment #2)
> Ah, I didn't know IRI was an actual thing. Sorry about that. Maybe you should
> at least add a translator comment to explain what it's supposed to mean?

Are you a translator? If so, I would be happy for you to copy/paste/add a comment as you see fit! :)
Comment 4 Alexandre Franke 2014-08-22 09:46:40 UTC
I am. I would need to understand what IRI is first. :)

What is it an acronym for?
Comment 6 Martyn Russell 2014-08-22 10:58:39 UTC
Thanks André.
Aleksander, I also have a link which might be of interest:
http://blog.4psa.com/url-urn-uri-iri-why-so-many/
Comment 7 Martyn Russell 2014-09-17 09:22:44 UTC
(In reply to comment #4)
> I am. I would need to understand what IRI is first. :)
> 
> What is it an acronym for?

Quoting from the article I linked to:

"IRI (International Resource Identifier) is a generalization of the URI. While URI supports only ASCI encoding, IRI fully supports international characters. In practice, UTF-8 is the most popular encoding used for IRI."

Since tracker-info is used on UTF-8 based terminals and we heavily use UTF-8 internally in Tracker, I would say it's currently correct as-is.

I will mark as NOTABUG. Feel free to re-open if you have a counter argument.

Thanks for reporting the bug ;)
Comment 8 Alexandre Franke 2014-09-17 09:28:09 UTC
Did you add a comment? :-)

If you didn't should I reopen this report or file a new one?
Comment 9 Martyn Russell 2014-09-17 09:34:05 UTC
(In reply to comment #8)
> Did you add a comment? :-)
> 
> If you didn't should I reopen this report or file a new one?

So, the bug is about IRI being a typo, which it isn't.
But! :) if you want a comment I can do that. But I wonder why it's needed here?

Finally, I don't know think I can commit any fix or change here while we're in hard code freeze :/
Comment 10 Alexandre Franke 2014-09-17 09:48:33 UTC
It's needed because IRIs isn't as well known as URIs and translators a) will think it's a typo and/or b) need to find out how to translate it (yes, sometimes acronyms have local variants, like NATO is OTAN in French).
Comment 11 Alexandre Franke 2014-09-17 18:14:48 UTC
(In reply to comment #9)
> Finally, I don't know think I can commit any fix or change here while we're in
> hard code freeze :/

So I just asked to release team members who confirmed that adding a comment doesn't break hard code freeze. Go ahead. :)
Comment 12 Martyn Russell 2014-09-19 09:20:32 UTC
Alexandre, thanks I've pushed a fix, let me know if you think the fix is not sufficient ;)
Comment 13 Alexandre Franke 2014-09-19 14:08:37 UTC
Perfect, thanks.