After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735171 - Unneeded modules in PKG_CHECK_MODULES
Unneeded modules in PKG_CHECK_MODULES
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-21 15:25 UTC by Michael Catanzaro
Modified: 2014-08-25 14:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't depend on gmodule (755 bytes, patch)
2014-08-21 15:25 UTC, Michael Catanzaro 		committed Details | Review
uri-tester: remove unused declaration (808 bytes, patch)
2014-08-21 15:25 UTC, Michael Catanzaro 		none Details | Review
Don't link with X11 (678 bytes, patch)
2014-08-23 00:35 UTC, Michael Catanzaro 		committed Details | Review
Revert "Don't link with X11" (864 bytes, patch)
2014-08-25 14:55 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-08-21 15:25:28 UTC 
See patches
Comment 1 Michael Catanzaro 2014-08-21 15:25:29 UTC 
Created attachment 284096 [details] [review]
Don't depend on gmodule

Since we no longer have a extension system, we don't need this anymore,
right?
Comment 2 Michael Catanzaro 2014-08-21 15:25:33 UTC 
Created attachment 284097 [details] [review]
uri-tester: remove unused declaration

This looks like a leftover from when this was the adblock extension.
Comment 3 Michael Catanzaro 2014-08-21 23:24:35 UTC 
Comment on attachment 284097 [details] [review]
uri-tester: remove unused declaration

Actually, I want to do this in a different patch.
Comment 4 Michael Catanzaro 2014-08-23 00:35:01 UTC 
Created attachment 284270 [details] [review]
Don't link with X11
Comment 5 Carlos Garcia Campos 2014-08-25 08:10:06 UTC 
Comment on attachment 284096 [details] [review]
Don't depend on gmodule

Ok, we already depend on it indirectly, I think.
Comment 6 Carlos Garcia Campos 2014-08-25 08:10:20 UTC 
Comment on attachment 284270 [details] [review]
Don't link with X11

Ok
Comment 7 Michael Catanzaro 2014-08-25 14:31:14 UTC 
Attachment 284096 [details] pushed as 886e5a0 - Don't depend on gmodule
Attachment 284270 [details] pushed as 7414968 - Don't link with X11
Comment 8 Michael Catanzaro 2014-08-25 14:55:52 UTC 
The following fix has been pushed:
17e50f7 Revert "Don't link with X11"
Comment 9 Michael Catanzaro 2014-08-25 14:55:55 UTC 
Created attachment 284411 [details] [review]
Revert "Don't link with X11"

This reverts commit 74149684d2207be221a71d3d70c1d3d59331046c.

This is needed in ephy-main.c. I have no idea why I was able to compile
without it when I wrote this commit. :/