GNOME Bugzilla – Bug 735153
Introduction text is unreadable (gray on a gray background)
Last modified: 2016-03-31 13:22:07 UTC
It is quite difficult to read the text displayed the first time boxes is started. See https://people.gnome.org/~fpeters/gnome-boxes-gray-on-gray.png
I believe this is a regression from bug#731952.
Created attachment 284116 [details] Reworked version How's this? (Patch will follow shortly.)
(In reply to comment #2) > Created an attachment (id=284116) [details] > Reworked version > > How's this? (Patch will follow shortly.) Much better but still a bit dark IMHO.
Created attachment 284118 [details] [review] boxes-empty-image: Use inherited color The hardcoded color doesnt play well with the new background. This makes the image better visible while having less hardcoded colors as a side effect.
Created attachment 284119 [details] [review] gtk-style: Remove .boxes-empty-details-label The .boxes-empty-details-label defines only the color while the inherited color improves readability. It is therefore of no use to have this class.
(In reply to comment #3) > (In reply to comment #2) > > Created an attachment (id=284116) [details] [details] > > Reworked version > > > > How's this? (Patch will follow shortly.) > > Much better but still a bit dark IMHO. I dont think the collor difference between background and foreground was higher than in my example. IMHO this is rather a subtle message and therefore shouldnt drain all attention to it.
Review of attachment 284119 [details] [review]: "The .boxes-empty-details-label defines only the color while the inherited color improves readability." Had to think hard to understand what this means. How about: The .boxes-empty-details-label class is redundant since it only sets color to improve readability while it ends up doing the opposite.
Review of attachment 284118 [details] [review]: ack
Review of attachment 284119 [details] [review]: In your description it sounds a bit like the original writer of .boxes-empty-details-label is to blame for that. Maybe its only me 'feeling' this subjective thing here. I dont want to blame anyone since its my fault because background changed. Otherwise I'm ok with you message, so go ahead and push. However its a UI change so you'd need permission, wouldnt you?
Review of attachment 284119 [details] [review]: That poor original writer was me. :) If this changed because of your changes, you can add that info of course. I just wasn't sure that your changes are responsible.
I noticed this again while testing 3.13.91, this could really be pushed :)
Created attachment 285289 [details] [review] boxes-empty-image: Use inherited color The hardcoded color doesnt play well with the new background. This makes the image better visible while having less hardcoded colors as a side effect.
Created attachment 285290 [details] [review] gtk-style: Remove .boxes-empty-details-label The .boxes-empty-details-label class is redundant since it only sets color to improve readability while it ends up doing the opposite since the restyle through commits 88d1119c to 787852bc. It is therefore of no use to have this class anymore.
Frederic: Thanks for notifying! Zeeshan: Sorry that this took so long. One exam per week while working on some days. I just modified the commit message of the second patch in the suggested direction.
Review of attachment 285289 [details] [review]: ack
Review of attachment 285290 [details] [review]: i could nitpick but never mind. :)
Attachment 285289 [details] pushed as b58f397 - boxes-empty-image: Use inherited color Attachment 285290 [details] pushed as 902a179 - gtk-style: Remove .boxes-empty-details-label