After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735115 - ephy-bookmark-properties: close is not an action
ephy-bookmark-properties: close is not an action
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
git master
Other All
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-20 18:38 UTC by Michael Catanzaro
Modified: 2014-08-25 14:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ephy-bookmark-properties: close is not an action (1.42 KB, patch)
2014-08-20 18:38 UTC, Michael Catanzaro 		committed Details | Review

Description Michael Catanzaro 2014-08-20 18:38:20 UTC 
This is the dialog you get when you open bookmarks from the app menu, right click a particular bookmark, and select Properties.
Comment 1 Michael Catanzaro 2014-08-20 18:38:22 UTC 
Created attachment 283987 [details] [review]
ephy-bookmark-properties: close is not an action

We use a traditional X button for close, we don't spell it out as a
suggested-action.

This dialog is a bit confusing because it is used for both creating and
viewing bookmarks. When creating bookmarks, it's an action dialog and we
need to use gtk_dialog_add_button() to create our choices (cancel at the
start of the header bar, and suggested Add at the end). But when not
creating a bookmark, it's a presentation dialog and so calling
gtk_dialog_add_button() is wrong.
Comment 2 Carlos Garcia Campos 2014-08-25 07:51:53 UTC 
Review of attachment 283987 [details] [review]:

Ok
Comment 3 Michael Catanzaro 2014-08-25 14:30:25 UTC 
Attachment 283987 [details] pushed as 1a0ad7b - ephy-bookmark-properties: close is not an action