After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735110 - Annotation window icons for closing and re-sizing are huge
Annotation window icons for closing and re-sizing are huge
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: pdf annotations
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-20 15:57 UTC by giselle
Modified: 2014-08-29 17:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Funny looking annotation window (66.42 KB, image/png)
2014-08-20 15:57 UTC, giselle 		  Details
Setting annotation window icon sizes (2.91 KB, patch)
2014-08-20 16:04 UTC, giselle 		accepted-commit_now Details | Review
Removing ev_annotation_window_get_icon_size (1.31 KB, patch)
2014-08-20 16:07 UTC, giselle 		accepted-commit_now Details | Review

Description giselle 2014-08-20 15:57:55 UTC 
Created attachment 283976 [details]
Funny looking annotation window

The screenshot attached shows the problem with the huge icons. Also, the window is black because of another bug (https://bugzilla.gnome.org/show_bug.cgi?id=732211).
Comment 1 giselle 2014-08-20 16:04:25 UTC 
Created attachment 283977 [details] [review]
Setting annotation window icon sizes

The patch solves the problem with the icon sizes by loading them directly from the icon theme, as recommended on Gtk documentation. According to them, the function gtk_icon_size_register is deprecated and should not be used.
Comment 2 giselle 2014-08-20 16:07:54 UTC 
Created attachment 283978 [details] [review]
Removing ev_annotation_window_get_icon_size

With the previous patch, this function is no longer used.
Comment 3 Carlos Garcia Campos 2014-08-29 15:32:05 UTC 
Comment on attachment 283977 [details] [review]
Setting annotation window icon sizes

Thanks!
Comment 4 Carlos Garcia Campos 2014-08-29 15:32:31 UTC 
Comment on attachment 283978 [details] [review]
Removing ev_annotation_window_get_icon_size

Cool
Comment 5 giselle 2014-08-29 17:55:43 UTC 
Cool, pushed both to master. Thanks :)