After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735093 - Use gtk_application_inhibit()
Use gtk_application_inhibit()
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-20 10:23 UTC by Phillip Wood
Modified: 2014-09-01 14:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use gtk_application_inhibit() (7.47 KB, patch)
2014-08-20 10:23 UTC, Phillip Wood 		committed Details | Review

Description Phillip Wood 2014-08-20 10:23:29 UTC 
Now that we require Gtk 3.4 it makes sense use the inhibit
functionality provided by GtkApplication rather than doing the DBus
calls ourselves.
Comment 1 Phillip Wood 2014-08-20 10:23:32 UTC 
Created attachment 283959 [details] [review]
Use gtk_application_inhibit()
Comment 2 Bastien Nocera 2014-08-21 10:28:15 UTC 
Review of attachment 283959 [details] [review]:

::: src/sj-extracting.c
@@ +826,3 @@
+  cookie = gtk_application_inhibit (GTK_APPLICATION (g_application_get_default ()),
+                                    GTK_WINDOW (main_window),
+                                    GTK_APPLICATION_INHIBIT_SUSPEND | GTK_APPLICATION_INHIBIT_IDLE,

Suspend and switch user look like more valid flags, but the switch should be done in a separate commit.
Comment 3 Phillip Wood 2014-09-01 14:23:51 UTC 
Thank for the review
Attachment 283959 [details] pushed as 325abe3 - Use gtk_application_inhibit()

>Suspend and switch user look like more valid flags, but the switch 
>should be done in a separate commit.
Yes that makes more sense, pushed as 827e9b2 - Change GtkApplicationInhibit flags