After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735091 - Replace g_list_deep_free() with g_list_free_full()
Replace g_list_deep_free() with g_list_free_full()
Status: RESOLVED FIXED
Product: sound-juicer
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: Sound Juicer Maintainers
Sound Juicer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-20 10:22 UTC by Phillip Wood
Modified: 2014-09-05 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Replace g_list_deep_free() with g_list_free_full() (3.92 KB, patch)
2014-08-20 10:22 UTC, Phillip Wood 		committed Details | Review

Description Phillip Wood 2014-08-20 10:22:14 UTC 
Now that g_list_free_full() is in GLib we don't need to roll our own
version. Also use g_list_free_full() rather than g_list_foreach()
followed by g_list_free() to free a list and it's data.
Comment 1 Phillip Wood 2014-08-20 10:22:43 UTC 
Created attachment 283957 [details] [review]
Replace g_list_deep_free() with g_list_free_full()
Comment 2 Bastien Nocera 2014-08-21 10:30:22 UTC 
Review of attachment 283957 [details] [review]:

Rest looks good.

::: libjuicer/rb-gst-media-types.c
@@ +327,2 @@
 			ret = TRUE;
+			g_list_free_full (messages, (GDestroyNotify)gst_message_unref);

I'd make the change in rhythmbox if necessary first, as it's a copy/paste file.
Comment 3 Phillip Wood 2014-09-04 10:39:09 UTC 
I've just checked in rhythmbox and it has never had rb_gst_check_missing_plugins() so there's nothing to change there (there are no calls to g_list_* in the whole file).
Comment 4 Phillip Wood 2014-09-05 10:08:32 UTC 
Thanks for the review.
Attachment 283957 [details] pushed as 8c5bb72 - Replace g_list_deep_free() with g_list_free_full()