After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735076 - Make use of instance-argument annotations
Make use of instance-argument annotations
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-20 00:47 UTC by Simon Feltman
Modified: 2017-03-22 08:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Make use of instance-argument annotations (2.06 KB, patch)
2017-03-21 13:07 UTC, Christoph Reiter (lazka) 		committed Details | Review

Description Simon Feltman 2014-08-20 00:47:12 UTC 
Now that bug 729662 is fixed we have an API for getting instance argument transfer annotations, we should make use of it in the bindings.

Basically using:

g_callable_info_get_instance_ownership_transfer()

where we fill create the instance cache:
https://git.gnome.org/browse/pygobject/tree/gi/pygi-cache.c?id=3.13.90#n909

This will also require a version dependency bump on GI.
Comment 1 Christoph Reiter (lazka) 2017-03-21 13:07:59 UTC 
Created attachment 348407 [details] [review]
Make use of instance-argument annotations

Use g_callable_info_get_instance_ownership_transfer() instead
of hardcoding the transfer for instances.

get_instance_ownership_transfer() is available since 1.42.0, so no
version dependency bump is required.
Comment 2 Simon Feltman 2017-03-22 07:29:43 UTC 
Review of attachment 348407 [details] [review]:

Perfect, thank you.
Comment 3 Christoph Reiter (lazka) 2017-03-22 08:33:06 UTC 
Thanks