GNOME Bugzilla – Bug 735073
[PATCHes] Use GtkBuilder.
Last modified: 2014-09-15 23:23:57 UTC
Created attachment 283923 [details] [review] Remove tabs. Now that the UI is frozen, let’s change the code! =D (Didn’t I already told that somewhere?) The first patch is only cleaning, the second does the job.
Created attachment 283924 [details] [review] Use GtkBuilder.
Review of attachment 283923 [details] [review]: OK
Review of attachment 283924 [details] [review]: Looks good. ::: data/Makefile.am @@ +42,3 @@ $(sounds_DATA) \ $(velena_DATA) \ + $(appdata_in_files) \ Make sure to use the same whitespace as the rest of this list. ::: src/main.c @@ +1177,3 @@ + gtk_style_context_add_provider_for_screen (gdk_screen_get_default (), css_provider, GTK_STYLE_PROVIDER_PRIORITY_APPLICATION); + + builder = gtk_builder_new_from_file (DATA_DIRECTORY "/four-in-a-row.ui"); // TODO errors management? Nope, that function will abort the program if it fails, since there's nothing else to do if you have no UI. @@ +1181,3 @@ + window = gtk_builder_get_object (builder, "fiar-window"); + gtk_window_set_application (GTK_WINDOW (window), application); + //gtk_window_set_title (GTK_WINDOW (window), _(APPNAME_LONG)); Make sure to remove this comment
Created attachment 283940 [details] [review] Use GtkBuilder.
Created attachment 283941 [details] [review] Remove tabs. No, that’s not the same as the first. ^^
Review of attachment 283941 [details] [review]: OK if the file was primarily non-tabs to begin with. (Tabs are nicer in Makefile.am.)
Review of attachment 283941 [details] [review]: ::: data/Makefile.am @@ +53,3 @@ check-local: $(appdata_DATA) $(desktop_DATA) + $(APPDATA_VALIDATE) $(appdata_DATA) + $(DESKTOP_FILE_VALIDATE) $(desktop_DATA) Actually, you have to use tabs here :)
Review of attachment 283940 [details] [review]: Thanks!
Created attachment 284861 [details] [review] Use GtkBuilder. > Actually, you have to use tabs here :) So, I won’t touch this makefile. ^^ Here is an update of the GtkBuilder patch, build on top of “Ensure buttons have the same width”[1], and of course updating the properties. [1] https://bugzilla.gnome.org/show_bug.cgi?id=735698
Review of attachment 284861 [details] [review]: Looks good.
(In reply to comment #0) > Created an attachment (id=283923) [details] [review] > Remove tabs. Unfortunately this one needs rebased :(
Created attachment 286242 [details] [review] Remove tabs. Yeah, one function had some little changes. Here is an updated “Remove tabs.” patch with new cleanings, you can apply after.
Thanks! Attachment 284861 [details] pushed as 992dc39 - Use GtkBuilder. Attachment 286242 [details] pushed as f6487e3 - Remove tabs.