After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735062 - runDialog: catch the case where no completion is available
runDialog: catch the case where no completion is available
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-19 16:39 UTC by Cosimo Cecchi
Modified: 2014-08-19 16:43 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
runDialog: catch the case where no completion is available (915 bytes, patch)
2014-08-19 16:39 UTC, Cosimo Cecchi 		committed Details | Review

Description Cosimo Cecchi 2014-08-19 16:39:48 UTC 
When trying to auto-complete a string that has no completion from the run dialog, an uncaught exception will be printed.
See patch.
Comment 1 Cosimo Cecchi 2014-08-19 16:39:58 UTC 
Created attachment 283913 [details] [review]
runDialog: catch the case where no completion is available

Just return null, instead of failing with an exception later trying to
call substr() on null.
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-08-19 16:40:59 UTC 
Review of attachment 283913 [details] [review]:

Looks good.
Comment 3 Cosimo Cecchi 2014-08-19 16:43:19 UTC 
Attachment 283913 [details] pushed as d54efe0 - runDialog: catch the case where no completion is available

Thanks, pushed to master.