After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735025 - Use text buttons
Use text buttons
Status: RESOLVED FIXED
Product: four-in-a-row
Classification: Applications
Component: general
git master
Other All
: Normal normal
: ---
Assigned To: four-in-a-row-maint
four-in-a-row-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-18 23:27 UTC by Michael Catanzaro
Modified: 2014-08-19 01:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Require GTK+ 3.13.2 (760 bytes, patch)
2014-08-18 23:27 UTC, Michael Catanzaro 		none Details | Review
Move undo button to header bar (2.43 KB, patch)
2014-08-18 23:27 UTC, Michael Catanzaro 		none Details | Review
Use text buttons for New Game and Hint (2.11 KB, patch)
2014-08-18 23:27 UTC, Michael Catanzaro 		none Details | Review
Layout near Iagno's and Sudoku's ones. (4.73 KB, patch)
2014-08-19 01:07 UTC, Arnaud B. 		accepted-commit_now Details | Review

Description Michael Catanzaro 2014-08-18 23:27:01 UTC 
The current buttons do not look like buttons
Comment 1 Michael Catanzaro 2014-08-18 23:27:02 UTC 
Created attachment 283848 [details] [review]
Require GTK+ 3.13.2

For automatic RTL icon support
Comment 2 Michael Catanzaro 2014-08-18 23:27:06 UTC 
Created attachment 283849 [details] [review]
Move undo button to header bar
Comment 3 Michael Catanzaro 2014-08-18 23:27:08 UTC 
Created attachment 283850 [details] [review]
Use text buttons for New Game and Hint
Comment 4 Arnaud B. 2014-08-19 01:07:30 UTC 
Created attachment 283852 [details] [review]
Layout near Iagno's and Sudoku's ones.

Here’s a layout near Iagno’s and Sudoku’s ones. There’s a problem of child-internal-pad-x of the button_box, (so?) the aspect_frame is 1.45 instead of 1.4, and some other things here and there to correct, but it’s a good beginning I think.
Comment 5 Michael Catanzaro 2014-08-19 01:19:38 UTC 
Review of attachment 283852 [details] [review]:

::: src/main.c
@@ +1234,3 @@
   /* set a min size to avoid pathological behavior of gtk when scaling down */
+  gtk_widget_set_size_request (drawarea, 350, 350);
+  //gtk_container_add (GTK_CONTAINER (gridframe), drawarea);

I'm going to remove this line when I commit
Comment 6 Michael Catanzaro 2014-08-19 01:20:30 UTC 
Review of attachment 283852 [details] [review]:

::: src/main.c
@@ +1224,3 @@
+  gtk_container_add (GTK_CONTAINER (frame), hbox);
+
+  /* gridframe = games_grid_frame_new (7, 7);

actually I'm going to remove this huge block too :p