GNOME Bugzilla – Bug 735021
daap source compilation failure with ubuntu 14.04
Last modified: 2014-08-18 23:44:03 UTC
The following error was observed when producing a test debian package build with ubuntu 14.04 with the latest git master Think this was due to the inclusion of the libsecret commit? - https://github.com/GNOME/rhythmbox/commit/f370706edfedffda1e74d80b806db73a36c5a54e Looking at the code the "#ifdef WITH_LIBSECRET" on line 491 of rb-daap-source.c should encompass the gchar *password ? or is rhythmbox now enforcing the use of libsecret and hence perhaps change the dependencies and remove the "#ifdef" statement? " -Wunused-label -Wunused-value -Wchar-subscripts -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wpointer-arith -Wcast-align -Wformat-security -Wall -Werror -Wno-deprecated-declarations -std=gnu89 -D_BSD_SOURCE -D_FORTIFY_SOURCE=2 -g -O2 -fstack-protector --param=ssp-buffer-size=4 -Wformat -Werror=format-security -Wall -c rb-daap-source.c -fPIC -DPIC -o .libs/libdaap_la-rb-daap-source.o rb-daap-source.c: In function 'connection_auth_cb': rb-daap-source.c:490:9: error: unused variable 'password' [-Werror=unused-variable] gchar *password = NULL; ^ cc1: all warnings being treated as errors make[5]: *** [libdaap_la-rb-daap-source.lo] Error 1 make[5]: Leaving directory `/home/dad/Downloads/rhythmbox-3.0.3/plugins/daap' make[4]: *** [all] Error 2 make[4]: Leaving directory `/home/dad/Downloads/rhythmbox-3.0.3/plugins/daap' make[3]: *** [all-recursive] Error 1 make[3]: Leaving directory `/home/dad/Downloads/rhythmbox-3.0.3/plugins' make[2]: *** [all-recursive] Error 1 make[2]: Leaving directory `/home/dad/Downloads/rhythmbox-3.0.3' make[1]: *** [all] Error 2 make[1]: Leaving directory `/home/dad/Downloads/rhythmbox-3.0.3' make: *** [debian/stamp-makefile-build] Error 2 dpkg-buildpackage: error: debian/rules build gave error exit status 2 debuild: fatal error at line 1364: dpkg-buildpackage -rfakeroot -D -us -uc failed "
checking the package version available in ubuntu 14.04 for "libsecret-1-dev" - it is v0.16. The commit referred to says v0.18 is mandated. Thus I presume either I should revert this particular commit for Ubuntu 14.04 - or the autogen dependencies should enforce v0.18 and later?
this has been broken since 2011, but no one noticed
fixed in commit 180fecf
thanks Jonathan, the whole tree now builds on Ubuntu 14.04. cheers