After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 735020 - Wrong cell marked as selected in RTL
Wrong cell marked as selected in RTL
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-18 22:22 UTC by Yosef Or Boczko
Modified: 2014-08-29 20:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot (123.32 KB, image/png)
2014-08-18 22:22 UTC, Yosef Or Boczko 		  Details
Handle RTL correctly. (979 bytes, patch)
2014-08-21 00:39 UTC, Arnaud B. 		committed Details | Review

Description Yosef Or Boczko 2014-08-18 22:22:02 UTC 
Created attachment 283835 [details]
Screenshot

Clicking on the third cell from left cause the third cell from right
to appear as the seleceted cell.
However, the popover appear above the right cell (the third cell from left),
and typing number of choosing number from the popover write the number
in the right cell (in the third cell from left).

Of course, vice a versa - clicking on the third cell from right...
Comment 1 Michael Catanzaro 2014-08-19 02:07:44 UTC 
Did we break this recently (like today?)

It might be intended as a brainteaser :)
Comment 2 Yosef Or Boczko 2014-08-19 08:33:37 UTC 
I think so.
Comment 3 Arnaud B. 2014-08-21 00:39:31 UTC 
Created attachment 284029 [details] [review]
Handle RTL correctly.

This is indeed a big bug and of course my fault. It was introduced in “Use Gtk.DrawingArea for the board”[1] (yay!), and looks like the simple way to correct it is just to invert the background drawing when we’re in a RTL context.

[1] https://git.gnome.org/browse/gnome-sudoku/commit/?id=1263d5ea90031aa8fc2dd9c72dbb8a326f320e79
Comment 4 Yosef Or Boczko 2014-08-21 11:03:06 UTC 
Review of attachment 284029 [details] [review]:

Works fine for me, thanks!
Comment 5 Parin Porecha 2014-08-29 20:57:32 UTC 
Comment on attachment 284029 [details] [review]
Handle RTL correctly.

Pushed as cd1132c