After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734999 - Make app D-Bus activatable
Make app D-Bus activatable
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: Movie player
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-18 13:47 UTC by Bastien Nocera
Modified: 2014-08-21 14:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
data: Rename totem's desktop file (5.83 KB, patch)
2014-08-18 16:06 UTC, Bastien Nocera 		reviewed Details | Review
data: Make Totem a D-Bus service (1.81 KB, patch)
2014-08-18 16:06 UTC, Bastien Nocera 		reviewed Details | Review
data: Rename totem's desktop file (3.27 KB, patch)
2014-08-21 13:23 UTC, Bastien Nocera 		committed Details | Review
data: Make Totem a D-Bus service (1.95 KB, patch)
2014-08-21 13:23 UTC, Bastien Nocera 		committed Details | Review

Description Bastien Nocera 2014-08-18 13:47:43 UTC 
It probably isn't so right now.
Comment 1 Bastien Nocera 2014-08-18 16:06:41 UTC 
Created attachment 283790 [details] [review]
data: Rename totem's desktop file

So that its name matches the application-id
Comment 2 Bastien Nocera 2014-08-18 16:06:48 UTC 
Created attachment 283791 [details] [review]
data: Make Totem a D-Bus service
Comment 3 Philip Withnall 2014-08-18 22:46:06 UTC 
Review of attachment 283790 [details] [review]:

::: data/totem-video-thumbnailer.1
@@ -1,1 @@
-.\" Automatically generated by Pod::Man 2.16 (Pod::Simple 3.07)

Irrelevant changes.
Comment 4 Philip Withnall 2014-08-18 22:47:45 UTC 
Review of attachment 283791 [details] [review]:

::: data/Makefile.am
@@ +57,3 @@
 
+servicedir = $(datadir)/dbus-1/services
+service_DATA = org.gnome.Totem.service

Might want to add $(service_DATA) to CLEANFILES, since it’s generated.
Comment 5 Bastien Nocera 2014-08-21 13:23:42 UTC 
Created attachment 284084 [details] [review]
data: Rename totem's desktop file

So that its name matches the application-id
Comment 6 Bastien Nocera 2014-08-21 13:23:48 UTC 
Created attachment 284085 [details] [review]
data: Make Totem a D-Bus service
Comment 7 Philip Withnall 2014-08-21 13:52:48 UTC 
Review of attachment 284085 [details] [review]:

Looks good to me.
Comment 8 Philip Withnall 2014-08-21 13:53:13 UTC 
Review of attachment 284084 [details] [review]:

Looks good to me.
Comment 9 Bastien Nocera 2014-08-21 14:28:39 UTC 
Attachment 284084 [details] pushed as 84609ac - data: Rename totem's desktop file
Attachment 284085 [details] pushed as d86decb - data: Make Totem a D-Bus service