After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734970 - codecparser: h264: Use proper bit_reader api while parsing buffering_period SEI
codecparser: h264: Use proper bit_reader api while parsing buffering_period SEI
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal major
: 1.5.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks: 722734 731852
 
 
Reported: 2014-08-17 22:28 UTC by sreerenj
Modified: 2014-08-21 13:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
codecparser: h264: Use proper bit_reader api while parsing buffering_period SEI (2.49 KB, patch)
2014-08-17 22:28 UTC, sreerenj 		committed Details | Review

Description sreerenj 2014-08-17 22:28:22 UTC 
Created attachment 283694 [details] [review]
codecparser: h264: Use proper bit_reader api while parsing  buffering_period SEI

Use proper bit_reader api for parsing initial_cpb_removal_delay and initial_cpb_remvoal_delay_offset fields of buffering_period SEI messages.
Comment 1 Tim-Philipp Müller 2014-08-18 10:40:32 UTC 
Are you sure this is right? Is the length of these parameters not dynamic?
Comment 2 Tim-Philipp Müller 2014-08-18 10:41:20 UTC 
e.g. see GstH264HRDParams; and also what libav does.
Comment 3 Tim-Philipp Müller 2014-08-18 10:45:00 UTC 
Actually nevermind, I misread something.
Comment 4 sreerenj 2014-08-18 10:57:22 UTC 
The initial_cpb_removal_delay and initial_cpb_removal_delay_offset fields have length in bits given by initial_cpb_removal_delay_length_minus1 + 1.
Here the initial_cpb_removal_delay_length_minus2 is a 5 bit field. And even the default value is 23. So we should use READ_UINT32 macro .
Comment 5 Tim-Philipp Müller 2014-08-18 11:00:49 UTC 
Yes, sorry. Pushed, thanks:

commit e93551d5b0e08eac5fd9ad899bf814cb8d349bd6
Author: Sreerenj Balachandran <sreerenj.balachandran@intel.com>
Date:   Sun Aug 17 01:42:05 2014 +0300

    codecparser: h264: Use proper bit_reader api while parsing buffering_period SEI
    
    https://bugzilla.gnome.org/show_bug.cgi?id=734970