GNOME Bugzilla – Bug 734958
Player bar - not enough space given to artist and track name
Last modified: 2016-01-11 14:22:06 UTC
Take a look at this screenshot: https://i.imgur.com/Dq0Iotq.png You elipzise the name of the artist and the track title, but you have a lot of space you could use. Ideally you should make the slider a bit smaller, and not elipsize the name of the track and artist that much. People usually prefer to know what they are listening to, while seeking inside tracks is a less common activity.
btw, the mockups show a much shorter slider https://wiki.gnome.org/Design/Apps/Music
The longer slider is based on a newer mockup: https://github.com/gnome-design-team/gnome-mockups/blob/master/music/wire-playback-buffer.png
Renaming for clarity - ellipsizing isn't the problem. It's the amount of space that is. I think I agree that the minimum width of the artist and track name could be larger.
Issue still valid on gnome 3.18.0
Can you give me a hint as to where I can find the width and height allotments in the player tool;bar in the code,I can't see to find them
(In reply to Karanbir Chahal from comment #5) > Can you give me a hint as to where I can find the width and height > allotments in the player tool;bar in the code,I can't see to find them Look at the data/PlayerToolbar.ui file. The slider's id is "progress_scale", and the artist and track name labels are part of the box "nowplaying_labels".
Created attachment 317079 [details] [review] gnome-music: increase the maximum width of the artist and track name To fix this bug I increased the max_width_chars of id "title" and "artist" from 12 to 42 so that it can use the space more efficiently.
Thank you for your patch. Since it is a layout/design change, I would like to have an ACK from one of our designers before pushing this. Could you please attach an screenshot to this bug?
screenshots before the patch http://imgur.com/H9dJeQp after the patch http://imgur.com/a3F5amm
The patch works fine from what I can see. My only concern is what a track name with 42 characters looks like - I've been unable to find one in my music collection. :)
i had a hindi song in my collection which consisted of 42 characters so i kept it :P
it still ellipsizes the text, so we would reduce significantly the number of ellipsized songs anyway (more than 42 chars).
Comment on attachment 317079 [details] [review] gnome-music: increase the maximum width of the artist and track name Thanks for you patch. It was pushed to master.