GNOME Bugzilla – Bug 734911
Remove the LED array
Last modified: 2014-09-17 14:17:50 UTC
The LED array confused Allan when he tried out Lights Off a while back. Note that this patch is not ready to be merged because it leaves black space on the right and bottom of the clutter stage. Not sure how to fix this.
Created attachment 283602 [details] [review] Remove the LED array Use left and right buttons in the header bar instead. The LED was reported to be too confusing (it's not clearly a level) and also too difficult to read compared to normal font.
Created attachment 283603 [details] [review] Require GTK+ 3.13.2 For automatic RTL icon support
Created attachment 283604 [details] [review] Remove the LED array Use left and right buttons in the header bar instead. The LED was reported to be too confusing (it's not clearly a level) and also too difficult to read compared to normal font.
Created attachment 283606 [details] [review] Remove the LED array Use left and right buttons in the header bar instead. The LED was reported to be too confusing (it's not clearly a level) and also too difficult to read compared to normal font.
Created attachment 283620 [details] [review] Remove the LED array This one fixes the black space problem.
Created attachment 283679 [details] Screenshot showing the applied patches This looks alright, I guess. A bit odd but better than before.
Attachment 283603 [details] pushed as ab30754 - Require GTK+ 3.13.2 Attachment 283620 [details] pushed as 6b59a05 - Remove the LED array
It will look better without the minimize button, I think.
Hey Michael, just tried to compile lightsoff on GTK+ 3.12.0 and it failed, but I saw the patch in this ticket. Is the dependency bump required? The code compiles and works fine on 3.12 too, and I doubt the dependency bump is required to make use of the automatic RTL icon support, I assume it would work if 3.13.2+ is installed, and it wouldn't if the user has an earlier version.
Right, it will work in LTR layouts just fine with GTK+ 3.12.0, but RTL layouts would then be broken and we don't want distros to ruin that (Debian-based distros like to mix different versions of GNOME software, so they will if we let them :), hence the version bump. You can locally modify configure.ac if you want to compile with GTK+ 3.12.