After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734883 - [patch attached] Use the correct desktop ID when querying location
[patch attached] Use the correct desktop ID when querying location
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
: 735601 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-08-15 20:02 UTC by Elad Alfassa
Modified: 2014-08-28 16:49 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Use the correct desktop ID when querying location (2.42 KB, patch)
2014-08-15 20:02 UTC, Elad Alfassa 		rejected Details | Review
Use the correct desktop ID when querying location (944 bytes, patch)
2014-08-16 14:06 UTC, Elad Alfassa 		needs-work Details | Review
geoclue: Report correct desktop ID (961 bytes, patch)
2014-08-16 20:17 UTC, Elad Alfassa 		accepted-commit_now Details | Review

Description Elad Alfassa 2014-08-15 20:02:07 UTC 
Created attachment 283566 [details] [review]
Use the correct desktop ID when querying location

The shell will only approve location requests if the desktop file ID that they provide to geoclue2 is a valid desktop file ID. gnome-maps changed the desktop file ID not so long ago, and since then any attempt to use geoclue2 in gnome-maps will result in an Access Denied error.
Comment 1 Jonas Danielsson 2014-08-16 12:54:51 UTC 
Review of attachment 283566 [details] [review]:

Did you happend to append the wrong patch?
Comment 2 Elad Alfassa 2014-08-16 14:06:16 UTC 
Created attachment 283595 [details] [review]
Use the correct desktop ID when querying location

Oops, yeah, this was the wrong patch.

Here's the correct one
Comment 3 Zeeshan Ali 2014-08-16 20:10:34 UTC 
Review of attachment 283595 [details] [review]:

patch is good but commit log could be better:

geoclue: Report correct desktop ID (Short log is ideally supposed to be <= 50 chars)

Report correct desktop to geoclue, otherwise gnome-shell will deny location requests (Please break the line at appropriate place to fit in 74 chars limit).

https://wiki.gnome.org/Git/CommitMessages
Comment 4 Elad Alfassa 2014-08-16 20:17:35 UTC 
Created attachment 283622 [details] [review]
geoclue: Report correct desktop ID

Better?
Comment 5 Zeeshan Ali 2014-08-16 20:20:01 UTC 
Review of attachment 283622 [details] [review]:

yes :)
Comment 7 Zeeshan Ali 2014-08-28 16:49:31 UTC 
*** Bug 735601 has been marked as a duplicate of this bug. ***