After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734837 - media_art_get_path() usage is unclear
media_art_get_path() usage is unclear
Status: RESOLVED FIXED
Product: libmediaart
Classification: Other
Component: Cache
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Martyn Russell
: 731660 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-08-15 08:35 UTC by Bastien Nocera
Modified: 2014-09-10 08:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to fix the bug (8.20 KB, patch)
2014-08-15 10:30 UTC, Martyn Russell 		reviewed Details | Review

Description Bastien Nocera 2014-08-15 08:35:49 UTC 
I was expecting path and local_uri to be 2 versions of the exact same variable, but it turns out they're getting data from different locations. This is very confusing (see bug 734636) and not mentioned at all in the API documentation.
Comment 1 Martyn Russell 2014-08-15 10:30:03 UTC 
Created attachment 283444 [details] [review]
Patch to fix the bug

Hi Bastien, how does this patch look? I wanted to be sure the documentation was clear enough before committing this. Let me know what you think.
Comment 2 Bastien Nocera 2014-08-15 12:56:15 UTC 
Review of attachment 283444 [details] [review]:

Much better. But I would make the API change in a separate commit.
Comment 3 Martyn Russell 2014-08-15 12:58:54 UTC 
(In reply to comment #2)
> Review of attachment 283444 [details] [review]:
> 
> Much better. But I would make the API change in a separate commit.

Thanks.

I would have but I accidentally committed it already :)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 4 Martyn Russell 2014-09-10 08:56:46 UTC 
*** Bug 731660 has been marked as a duplicate of this bug. ***