GNOME Bugzilla – Bug 734822
playsinkconvertbin: only intersect with the filter at the end
Last modified: 2014-08-18 11:55:56 UTC
This improves caps negotiation to avoid returning caps that it will not support. The issue arrises when a caps has a certain capsfeatures X and the cached converter_caps has ANY caps features. When the intersection of the cached caps with the filter happens it transforms the ANY into X and those features are not excluded in the loop. If the sink doesn't accept those features it would cause a not-negotiated issue later when the caps event is passed.
Created attachment 283415 [details] [review] playsinkconvertbin: only intersect with the filter at the end Otherwise we might change some capsfeatures from ANY to the specific value from the filter and do not filter those out in case the sink doesn't support them
commit 98ed3ddc8f816588fc0bf015493bd8639286d30e Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Thu Aug 14 16:57:01 2014 -0300 playsinkconvertbin: only intersect with the filter at the end Otherwise we might change some capsfeatures from ANY to the specific value from the filter and do not filter those out in case the sink doesn't support them https://bugzilla.gnome.org/show_bug.cgi?id=734822 and 1.4: commit 8bccda365afcd3004e593b87a9b0aff1e02fc9a8 Author: Thiago Santos <thiagoss@osg.samsung.com> Date: Thu Aug 14 16:57:01 2014 -0300 playsinkconvertbin: only intersect with the filter at the end Otherwise we might change some capsfeatures from ANY to the specific value from the filter and do not filter those out in case the sink doesn't support them https://bugzilla.gnome.org/show_bug.cgi?id=734822