After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734816 - Navigation problem in viewer after save a photo
Navigation problem in viewer after save a photo
Status: RESOLVED FIXED
Product: shotwell
Classification: Other
Component: viewer-mode
0.18.x
Other Linux
: Normal normal
: 0.26
Assigned To: Shotwell Maintainers
Shotwell Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-14 19:58 UTC by Federico Reghenzani
Modified: 2017-03-04 07:20 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
viewer: Don't always add photo again after saving (1.27 KB, patch)
2017-03-04 07:14 UTC, Jens Georg
none Details | Review
viewer: Don't always add photo again after saving (1.27 KB, patch)
2017-03-04 07:17 UTC, Jens Georg
committed Details | Review

Description Federico Reghenzani 2014-08-14 19:58:53 UTC
Navigation in photos has problem after edit and save a photo.

Steps to reproduce:
- open an image
- edit (e.g. crop)
- press right and when asked saving dialog, save the image
- return to image edited pressing left arrow
- now pressing another time left: nothing happens.
Comment 1 Jens Georg 2017-03-03 22:50:22 UTC
Issue is that the viewer gets stuck because for some reason the previous photo is the current one
Comment 2 Jens Georg 2017-03-03 23:10:37 UTC
Problem is that save() in DirectPhotoPage unconditionally adds the photo to the dataview. For a save operation this is duplicating the photo in the view, causing display issues on crop and the navigation problem.

It should only add the photo if it didn't previously exist in the collection
Comment 3 Jens Georg 2017-03-04 07:14:14 UTC
Created attachment 347189 [details] [review]
viewer: Don't always add photo again after saving

This seems to cause the photo being in the collection twice, causing
not being able to navigate to the previous photo anymore

Just do it when the photo we save isn't the current photo.

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 4 Jens Georg 2017-03-04 07:17:40 UTC
Created attachment 347190 [details] [review]
viewer: Don't always add photo again after saving

This seems to cause the photo being in the collection twice, causing
not being able to navigate to the previous photo anymore

Just do it when the photo we save isn't the current photo.

Signed-off-by: Jens Georg <mail@jensge.org>
Comment 5 Jens Georg 2017-03-04 07:20:06 UTC
Attachment 347190 [details] pushed as 83aa387 - viewer: Don't always add photo again after saving