GNOME Bugzilla – Bug 734808
Window seems very tall
Last modified: 2014-09-18 17:00:16 UTC
Created attachment 283401 [details] screenshot See attached screenshot - taken with master from today.
Jasper has pushed some tweaks that reduce window size slightly
(In reply to comment #1) > Jasper has pushed some tweaks that reduce window size slightly So is this still an issue?
(In reply to comment #2) > (In reply to comment #1) > > Jasper has pushed some tweaks that reduce window size slightly > > So is this still an issue? I just tested with master and it still seems to be an issue, yes. The extra height seems to be coming from the location panel. One potential solution I discussed with Jasper was to remove the big icon from that page (the visual interest is provided by the map in this case).
I would hate to do that, since it breaks the nice uniform page setup we have going for all the other pages
Wild ideas: put the explanatory text ("We think that your timezone is...") in a popover on the map, move the search button up, and have the entry replace the title ?
Created attachment 285387 [details] location page (In reply to comment #4) > I would hate to do that, since it breaks the nice uniform page setup we have > going for all the other pages Given that the height is coming from that page, I'm not sure what the other option is, other than removing the icons from all the pages. I've attached a screenshot of the location page for reference.
put the search button in the header and use a search bar ?
(In reply to comment #7) > put the search button in the header and use a search bar ? I don't see how that would save any space - you still need the explanatory text. Besides, the vertical space taken up by search and the explanation is a fraction of what we need to recover.
Created attachment 285392 [details] hiding the icon For comparison, here is how much smaller the page gets by just hiding the icon.
Created attachment 285395 [details] using an overlay and hiding the text another comparison; didn't bother to put the search button in the header here
to give some numbers: without big icon: 746 pixels (including window frame) with overlay: 758 current: 836
(In reply to comment #11) > to give some numbers: > > without big icon: 746 pixels (including window frame) > with overlay: 758 > current: 836 Something around 760 should be OK in terms of layout/window proportions. I'm not entirely sure about the overlay approach though...
*** Bug 735534 has been marked as a duplicate of this bug. ***
There are quite a few 13" laptops out there with a screen resolution of 1280x720 (aka 720p). I think it would be unwise not to support them.
(In reply to comment #12) > (In reply to comment #11) > > to give some numbers: > > > > without big icon: 746 pixels (including window frame) > > with overlay: 758 > > current: 836 > > Something around 760 should be OK in terms of layout/window proportions. I'm > not entirely sure about the overlay approach though... FWIW, we should support 600 height. It already works at that height for the control-center.
I've made changes to limit the height to 768 pixels now; 600 is quite unrealistic without changes to most pages.
(In reply to comment #16) > I've made changes to limit the height to 768 pixels now; 600 is quite > unrealistic without changes to most pages. And what about the concerns for 1280x720 or 2560x1440 (HiDPI) systems?
(In reply to comment #17) > (In reply to comment #16) > > I've made changes to limit the height to 768 pixels now; 600 is quite > > unrealistic without changes to most pages. > > And what about the concerns for 1280x720 or 2560x1440 (HiDPI) systems? I can sympathize, but I can't do magic. The bug is still open, I'll happily review patches that get attached here.
Created attachment 286303 [details] [review] spacing patch This patch adjusts the spacing a bit. I was mostly attempting to make the layout more balanced and a little more compact. It seems to make the window shorter, although I wasn't aiming for a particular target height. Two issues that I noticed while doing this: 1. The "Time Zone" heading is vertically misaligned. It needs to be much closer to the content below; couldn't figure out how to do that though. 2. The subtitle on the goa page isn't correctly horizontally aligned. It should be left-aligned against the list below - right now it is centered, even when left-justified.
Created attachment 286331 [details] [review] timezone: Vertically center the title With the image now hidden, the title needs to be centered.
Created attachment 286332 [details] [review] goa: Fix alignment of subtitle As this is a multi-line subtitle, it should be left-aligned with the list below it. Make it so.
Attachment 286331 [details] pushed as 14124fc - timezone: Vertically center the title Attachment 286332 [details] pushed as a973a33 - goa: Fix alignment of subtitle