After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734787 - Fails to build with latest vala
Fails to build with latest vala
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
git master
Other Linux
: Normal critical
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-08-14 12:17 UTC by Vadim Rutkovsky
Modified: 2014-08-14 13:18 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Vadim Rutkovsky 2014-08-14 12:17:11 UTC
Gnome terminal fails to build after vala's commit https://git.gnome.org/browse/vala/commit/?id=29b93a27ddffb0cd77cdf44281a8889c22aff994.

From http://build.gnome.org/continuous/buildmaster/builds/2014/08/14/22/build/log-gnome-terminal.txt:
gterminal.vala:24.5-24.29: error: accessibility of struct fields can only be `public`
mv -f .deps/gnome_terminal_migration-terminal-profiles-list.Tpo .deps/gnome_terminal_migration-terminal-profiles-list.Po
    private static bool quiet = false;
    ^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:25.5-25.31: error: accessibility of struct fields can only be `public`
    private static bool verbose = false;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:115.5-115.37: error: accessibility of struct fields can only be `public`
    private static string[]? pass_fds = null;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:116.5-116.34: error: accessibility of struct fields can only be `public`
    private static bool pass_stdin = false;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:117.5-117.35: error: accessibility of struct fields can only be `public`
    private static bool pass_stdout = false;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:118.5-118.35: error: accessibility of struct fields can only be `public`
    private static bool pass_stderr = false;
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
gterminal.vala:119.5-119.60: error: accessibility of struct fields can only be `public`
    private static Terminal.Client.PassFdElement[]? fd_array = null;
Comment 1 Luca Bruno 2014-08-14 12:31:18 UTC
commit e0adb081fc11e563b037e19b2b85bcdc93a437c3
Author: Luca Bruno <lucabru@src.gnome.org>
Date:   Thu Aug 14 14:28:21 2014 +0200

    parser: Report error only for private instance fields in structs
    
    Fixes bug 734787

Fixed in Vala.