After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734758 - Tweak Tool Can't Install Local Gnome Shell Extensions File
Tweak Tool Can't Install Local Gnome Shell Extensions File
Status: RESOLVED FIXED
Product: gnome-tweak-tool
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Tweak Tool maintainer(s)
GNOME Tweak Tool maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-14 02:04 UTC by Paulie Pena
Modified: 2014-09-22 16:00 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix old call to notify_action_required (1.21 KB, patch)
2014-09-20 20:34 UTC, Gian Mario Tagliaretti 		none Details | Review
Patch to fix the wrong call to notify_action_required (1.83 KB, patch)
2014-09-22 07:57 UTC, Gian Mario Tagliaretti 		accepted-commit_after_freeze Details | Review

Description Paulie Pena 2014-08-14 02:04:27 UTC 
This is the error I get when I try to install a local zip file:
Traceback (most recent call last):

+ Trace 233951

  • File "/usr/lib/python2.7/site-packages/gtweak/tweaks/tweak_group_shell_extensions.py", line 252 in _on_file_set 
    self.notify_action_required(
AttributeError: '_ShellExtensionInstallerTweak' object has no attribute 'notify_action_required' 

This is the block of code that has the undefined function call:
  self.notify_action_required(verb, _("Restart"), self._shell.restart)

When I uncomment that bad function call, it seems to load the extension, but nothing happens. This does not show it added:
  gsettings get org.gnome.shell enabled-extensions
Comment 1 Gian Mario Tagliaretti 2014-09-20 20:34:39 UTC 
Created attachment 286705 [details] [review]
Fix old call to notify_action_required
Comment 2 Gian Mario Tagliaretti 2014-09-22 07:57:41 UTC 
Created attachment 286781 [details] [review]
Patch to fix the wrong call to notify_action_required

Also fix the signature of _logout() function (NotifyActionCallback) which should take 5 parameters and not four.
Comment 3 Rui Matos 2014-09-22 15:03:00 UTC 
Review of attachment 286781 [details] [review]:

Looks good, thanks
Comment 4 Gian Mario Tagliaretti 2014-09-22 16:00:22 UTC 
Thanks Rui, committed with a79bdbd1ecc2931cff03a8a7b614f47b2be07620