After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734749 - libvirt-machine-props: min resources can have empty value for storage
libvirt-machine-props: min resources can have empty value for storage
Status: RESOLVED FIXED
Product: gnome-boxes
Classification: Applications
Component: properties
3.13.x
Other Linux
: Normal normal
: 3.22
Assigned To: Fabiano Fidêncio
GNOME Boxes maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-08-13 22:51 UTC by Fabiano Fidêncio
Modified: 2016-03-31 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
libvirt-machine-props: min resources can have empty value for storage (1.15 KB, patch)
2014-08-13 22:51 UTC, Fabiano Fidêncio 		none Details | Review
libvirt-machine-props: min resources can have empty value for storage (1.15 KB, patch)
2014-08-14 00:13 UTC, Fabiano Fidêncio 		needs-work Details | Review
v2: libvirt-machine-props: Handle missing mim storage info (1.16 KB, patch)
2014-08-14 23:57 UTC, Fabiano Fidêncio 		committed Details | Review

Description Fabiano Fidêncio 2014-08-13 22:51:54 UTC 
Created attachment 283332 [details] [review]
libvirt-machine-props: min resources can have empty value for storage

see the attached patch
Comment 1 Fabiano Fidêncio 2014-08-14 00:13:36 UTC 
Created attachment 283336 [details] [review]
libvirt-machine-props: min resources can have empty value for storage
Comment 2 Zeeshan Ali 2014-08-14 12:54:48 UTC 
Review of attachment 283336 [details] [review]:

Log can use improvement (Can't tell number of characters here so please break lines appropriately in the log):

libvirt-machine-props: Handle missing min storage info

Checking only for minimum resources being non-null is not enough, we need to also ensure min storage is known before using that information.
Comment 3 Fabiano Fidêncio 2014-08-14 23:57:58 UTC 
Created attachment 283420 [details] [review]
v2: libvirt-machine-props: Handle missing mim storage info
Comment 4 Zeeshan Ali 2014-08-15 12:00:16 UTC 
Review of attachment 283420 [details] [review]:

mim -> min :)

Find otherwise.
Comment 5 Fabiano Fidêncio 2014-08-15 16:35:06 UTC 
Pushed upstream (3.13.90+)