After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734741 - GtkScale's fill-level starts at the very left if show-fill-level is set
GtkScale's fill-level starts at the very left if show-fill-level is set
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.13.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-08-13 20:11 UTC by Timm Bäder
Modified: 2015-03-25 02:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of testscale with recent gtk+ and adwaita (13.18 KB, image/png)
2014-08-13 20:11 UTC, Timm Bäder 		  Details
GtkRange: Fix drawing of fill-level (4.29 KB, patch)
2015-03-24 22:59 UTC, Marcus Karlsson 		committed Details | Review

Description Timm Bäder 2014-08-13 20:11:09 UTC 
Created attachment 283325 [details]
Screenshot of testscale with recent gtk+ and adwaita

See attached screenshot.
Comment 1 Matthias Clasen 2014-08-13 22:45:29 UTC 
hmm, annoying. If you want to look into this, the function to investigate is gtkrange.c:gtk_range_draw
Comment 2 Marcus Karlsson 2015-03-24 22:59:20 UTC 
Created attachment 300238 [details] [review]
GtkRange: Fix drawing of fill-level

This patch attempts to correct the bug. The starting point and length of the area that should be drawn to fill the scale up to the fill level were not computed correctly. The calculation has been simplified by computing the proportion of the range that should be drawn and then using that to compute where to start drawing and how far to draw.
Comment 3 Matthias Clasen 2015-03-25 02:54:11 UTC 
thanks for the patch; works fine in my testing.
Comment 4 Matthias Clasen 2015-03-25 02:54:45 UTC 
Attachment 300238 [details] pushed as abf3d78 - GtkRange: Fix drawing of fill-level