After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734737 - GCC warns about various things when building GTK+ on W32
GCC warns about various things when building GTK+ on W32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-08-13 19:52 UTC by LRN
Modified: 2014-08-13 23:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix various warnings (8.02 KB, patch)
2014-08-13 19:52 UTC, LRN 		committed Details | Review

Description LRN 2014-08-13 19:52:40 UTC 
This is most of what is left after bug 734735 and bug 734736 are fixed.
Improper casts and types mostly, although the warning about sizeof (key_state)
may as well be a bug (due to array decay sizeof() returns size of a pointer),
and base_datadir = _gtk_get_datadir(); is clearly an attempt to free something
that shouldn't be freed.
Comment 1 LRN 2014-08-13 19:52:43 UTC 
Created attachment 283322 [details] [review]
Fix various warnings
Comment 2 Matthias Clasen 2014-08-13 22:53:44 UTC 
Review of attachment 283322 [details] [review]:

ok
Comment 3 LRN 2014-08-13 23:42:24 UTC 
Attachment 283322 [details] pushed as a0faf5a - Fix various warnings