After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734722 - Adding of Place Icons
Adding of Place Icons
Status: RESOLVED OBSOLETE
Product: gnome-maps
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on: 730896
Blocks: 731587
 
 
Reported: 2014-08-13 15:06 UTC by Rishi Raj Singh Jhelumi
Modified: 2018-03-26 12:41 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add base maki icons. (120.77 KB, patch)
2014-08-18 21:26 UTC, Rishi Raj Singh Jhelumi
none Details | Review

Description Rishi Raj Singh Jhelumi 2014-08-13 15:06:16 UTC
The patch is w.r.t bug #730896.
Geocode-glib maybe planning to deprecate their get_icon method and remove the poi icons.

In my POI patches also I am using the same set of maki (https://github.com/mapbox/maki) icons (even more) as is currently used by geocode-glib.

The location of these icons also needs to be decided.

From What I asked at IRC and according to https://wiki.gnome.org/HowDoI/ThemedIcons , icons should be installed at 
"$(DESTDIR)$(datadir)/icons/hicolor/scalable/places/poi-XXX.svg".

In the above case, if a library (geocode-glib) installs the icons to the same location and later uninstalls it, the maps won't be able to access it.
But, If geocode-glib is removing icons, we may not need worry :).

Or if we install to 
"$(DESTDIR)$(datadir)/icons/hicolor/scalable/places/gnome-maps-poi-xxx.svg"
this might be a safe bet.

Opinions ??
Comment 1 Rishi Raj Singh Jhelumi 2014-08-18 21:26:50 UTC
Created attachment 283829 [details] [review]
Add base maki icons.

In this patch the icons are installed to
$(DESTDIR)$(datadir)/icons/gnome/scalable/places/poi-xxx.svg;

If there is a collision with the Geocode Icons, we may change the location or change the name of the icon ('gnome-maps' as prefix).
Comment 2 GNOME Infrastructure Team 2018-03-26 12:41:13 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/gnome-maps/issues/13.