GNOME Bugzilla – Bug 734721
patch to compile under msys2 (mingw)
Last modified: 2018-09-21 16:24:48 UTC
Created attachment 283289 [details] [review] patch to compile under msys2 (mingw) the patch is only to make possible to compile libsecret under msys2 (mingw) i don't know if there are any side effects it is similar to https://bugzilla.gnome.org/show_bug.cgi?id=710755
Review of attachment 283289 [details] [review]: The patch makes sense in general. Although I'm very confused about how this would actually work. Will you have gnome-keyring running on Windows? Could you turn this into a proper git patch, that will include your author information, and a decent commit message? ::: libsecret-0.18-orig/configure.ac @@ +137,2 @@ while (g_main_context_iteration (NULL, FALSE)); +++ libsecret-0.18/secret-dbus-generated.c 2014-08-11 17:20:11.654067200 +0200 Could you remove all the generated code from your patch? We don't include that in git.
(In reply to comment #1) > Review of attachment 283289 [details] [review]: > > The patch makes sense in general. Although I'm very confused about how this > would actually work. Will you have gnome-keyring running on Windows? no: is gnome-keyring essentials for libsecret to work? as i said i only compile libsecret and i didn't test functionalities i use libsecret to build evolution-data-server; and i build the latter to use libcamel (but i have not yet tested) > > Could you turn this into a proper git patch, that will include your author > information, and a decent commit message? ok > > ::: libsecret-0.18-orig/configure.ac > @@ +137,2 @@ > while (g_main_context_iteration (NULL, FALSE)); > +++ libsecret-0.18/secret-dbus-generated.c 2014-08-11 17:20:11.654067200 > +0200 > > Could you remove all the generated code from your patch? We don't include that > in git. sure... i left them by mistake
(In reply to comment #2) > (In reply to comment #1) > > Review of attachment 283289 [details] [review] [details]: > > > > The patch makes sense in general. Although I'm very confused about how this > > would actually work. Will you have gnome-keyring running on Windows? > > no: is gnome-keyring essentials for libsecret to work? It won't do anything if gnome-keyring is not available on the dbus bus. But I guess that's what you want?
(In reply to comment #3) > (In reply to comment #2) > > (In reply to comment #1) > > > Review of attachment 283289 [details] [review] [details] [details]: > > > > > > The patch makes sense in general. Although I'm very confused about how this > > > would actually work. Will you have gnome-keyring running on Windows? > > > > no: is gnome-keyring essentials for libsecret to work? > > It won't do anything if gnome-keyring is not available on the dbus bus. But I > guess that's what you want? so, if i understand correctly, evolution-data-server (via libsecret) without gnome-keyring can't store password, but supposedly it'll continue to work is it right?
You'll have to ask the evolution developers, but my guess would be "Yes".
Andrea, any updates to this patch? I would take it and update it myself, but I don’t have an easy way to test it.
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/libsecret/issues/5.