GNOME Bugzilla – Bug 734717
geary should support elementary's contractor
Last modified: 2014-11-01 00:15:55 UTC
Geary should support elementary's contractor at least as a plugin. That way pantheon-files and other applications can make use of it and send files per e-mail.
According to Viko Adi Rahmawan a command parameter to attach a file on the new message window would be enough to easily create a contract file.
Geary already supports attachments on the command-line via a mailto: argument. The mailto: schema supports an "attach" or "attachment" parameter. This is how Geary interoperates with xdg-open, nautilus-sendto, and LibreOffice. Is that the only issue? If so, is there anything else Geary needs to do here?
A patch to fix this should include all the necessary files (I suspect it's only a geary.contract file) and the necessary CMake code to install it in the right place. It would be best if the installation code detected Contactor's presence before installing the file. Otherwise, there should be a ./configure switch to enable/disable it.
Sorry but i still dont get the contractor detection part. Do you mean that it need to install contract file only if we found contractor package installed or it only detect contractor presence when compiling? I dont know if CMake can do package detection on package installation (Im new to CMake). Thanks
CMake can do package detection, although I'm less sure about it discovering if an application is installed versus a developer package (i.e. headers, .pc file, etc.). I thought about this last night and realized I was being a bit strict. If we're only talking about one file being installed in a well-known location, then we don't need to go overboard. The patch should merely install the file to the location and remove it during uninstall. This would be very similar to how the .desktop file is treated (or, more simply, how the files in sql/ are installed/uninstalled).
Created attachment 283575 [details] [review] Add elementary contractor support
this patch will add contractor support in geary. it have a --disable-contract flag to disable contract installation when compiling I have to install two files one .contract file in share/contractor and one bash file in bin to support multiple files attachment
With your patch will pantheon-files be able to send files via Geary ?
files, calendar, scratch and in the future photos will be able to attach to email. that's the beauty of contractor. if the patch can make it into geary 0.8 and be backported by elementary you can have it in freya
I absolutely want that if you want you can claim the bug on bountysource.
Created attachment 283655 [details] [review] Previous patch cant open file wiht spaces
Viko, these patches have the contractor files but I don't see the changes to the CMake files.
Created attachment 288099 [details] [review] Add contractor support
Thanks! Pushed to master, commit 66dc46