GNOME Bugzilla – Bug 734711
tsdemux: update output segments on seek
Last modified: 2018-11-03 13:26:03 UTC
Created attachment 283263 [details] [review] update output segments on seek This fixes at least the case where a non flushing rate changing seek is done, but the new rate would not be communicated downstream. I'm not sure whether it'd be best to only set this when the seek is non flushing, assuming that downstream will resend a segment when stopping flushing...
Comment on attachment 283263 [details] [review] update output segments on seek I think we should only do that in pull mode, otherwise upstream will send us a segment event after the seek which should then be transformed by tsdemux.
This might be helpful ? It's a WIP patch to support updated TIME segments from upstream. http://cgit.freedesktop.org/~bilboed/gst-plugins-bad/commit/?h=trickmodes&id=bcde22f243a4cc6e053b7d89a435ee021d237214
Created attachment 283508 [details] [review] update output segments on seek in pull mode In pull mode only. Shame that my original test case is in push mode though :p
(In reply to comment #2) > This might be helpful ? It's a WIP patch to support updated TIME segments from > upstream. > > http://cgit.freedesktop.org/~bilboed/gst-plugins-bad/commit/?h=trickmodes&id=bcde22f243a4cc6e053b7d89a435ee021d237214 Thanks - upstream time segment handling wouldnt help my particular case, as upstream here is merely filesrc + typefind.
Created attachment 283515 [details] [review] update output segments on seek in pull mode Updated, the stream pad can be NULL.
-- GitLab Migration Automatic Message -- This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-bad/issues/169.