After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 734699 - Do not guess user's desired difficulty level
Do not guess user's desired difficulty level
Status: RESOLVED FIXED
Product: gnome-sudoku
Classification: Applications
Component: general
git master
Other All
: High blocker
: ---
Assigned To: gnome-sudoku-maint
gnome-sudoku-maint
Depends on:
Blocks:
 
 
Reported: 2014-08-13 02:15 UTC by Michael Catanzaro
Modified: 2014-08-18 19:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not guess user's desired difficulty level (1.44 KB, patch)
2014-08-13 02:15 UTC, Michael Catanzaro 		reviewed Details | Review
Do not guess user's desired difficulty level (2.15 KB, patch)
2014-08-17 16:50 UTC, Michael Catanzaro 		committed Details | Review
Screenshot (10.59 KB, image/png)
2014-08-18 17:40 UTC, Parin Porecha 		  Details
Hide the Back button in new game screen at startup (848 bytes, patch)
2014-08-18 18:35 UTC, Parin Porecha 		committed Details | Review

Description Michael Catanzaro 2014-08-13 02:15:47 UTC 
If the user has never played GNOME Sudoku before, or just has no games
in progress, show the new game screen when starting Sudoku rather than
badly guessing which difficulty level he might want to play.

Usually a game will be saved and launching Sudoku will take you straight
to a puzzle, but if not, one click is not a big deal.
Comment 1 Michael Catanzaro 2014-08-13 02:15:49 UTC 
Created attachment 283246 [details] [review]
Do not guess user's desired difficulty level
Comment 2 Parin Porecha 2014-08-13 14:20:46 UTC 
Review of attachment 283246 [details] [review]:

::: src/gnome-sudoku.vala
@@ +166,3 @@
             start_game (savegame.board);
         else
+            lookup_action ("new-game").activate (null);

instead of this, I think it'd be better to rename new_game_cb() to show_new_game_screen() and call it here.
Comment 3 Michael Catanzaro 2014-08-17 16:50:59 UTC 
Created attachment 283663 [details] [review]
Do not guess user's desired difficulty level

Whoops, missed this! Matter of preference, I think.
Comment 4 Parin Porecha 2014-08-17 22:15:14 UTC 
Comment on attachment 283663 [details] [review]
Do not guess user's desired difficulty level

Pushed as a3190e8
Comment 5 Parin Porecha 2014-08-18 17:34:19 UTC 
The 'Back' button in the new game screen does not get disabled at startup.

Clicking it takes me to the game playing screen without any board
Comment 6 Parin Porecha 2014-08-18 17:40:49 UTC 
Created attachment 283805 [details]
Screenshot
Comment 7 Parin Porecha 2014-08-18 18:35:20 UTC 
Created attachment 283815 [details] [review]
Hide the Back button in new game screen at startup
Comment 8 Michael Catanzaro 2014-08-18 19:17:37 UTC 
Review of attachment 283815 [details] [review]:

OK
Comment 9 Parin Porecha 2014-08-18 19:36:29 UTC 
Comment on attachment 283815 [details] [review]
Hide the Back button in new game screen at startup

Pushed as c550524